Skip to content

Commit 1b6602f

Browse files
committed
Fix bumpfee rpc "errors" return value
1 parent 7e96ecf commit 1b6602f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/wallet/rpcwallet.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2909,7 +2909,7 @@ UniValue bumpfee(const JSONRPCRequest& request)
29092909
UniValue errors(UniValue::VARR);
29102910
for (const std::string& err: feeBump.getErrors())
29112911
errors.push_back(err);
2912-
result.push_back(errors);
2912+
result.push_back(Pair("errors", errors));
29132913

29142914
return result;
29152915
}

test/functional/bumpfee.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ def test_simple_bumpfee_succeeds(rbf_node, peer_node, dest_address):
8888
sync_mempools((rbf_node, peer_node))
8989
assert rbfid in rbf_node.getrawmempool() and rbfid in peer_node.getrawmempool()
9090
bumped_tx = rbf_node.bumpfee(rbfid)
91+
assert_equal(bumped_tx["errors"], [])
9192
assert bumped_tx["fee"] - abs(rbftx["fee"]) > 0
9293
# check that bumped_tx propogates, original tx was evicted and has a wallet conflict
9394
sync_mempools((rbf_node, peer_node))

0 commit comments

Comments
 (0)