Skip to content

Commit 1bab9b2

Browse files
committed
Add script dump note to RPC help text and release notes
1 parent 68c1e00 commit 1bab9b2

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

doc/release-notes.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,10 @@ The `share/rpcuser/rpcuser.py` script was renamed to `share/rpcauth/rpcauth.py`.
100100
used to create `rpcauth` credentials for a JSON-RPC user.
101101

102102

103+
- `dumpwallet` now includes hex-encoded scripts from the wallet in the dumpfile, and
104+
`importwallet` now imports these scripts, but corresponding addresses may not be added
105+
correctly or a manual rescan may be required to find relevant transactions.
106+
103107
Credits
104108
=======
105109

src/wallet/rpcdump.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -613,7 +613,7 @@ UniValue dumpwallet(const JSONRPCRequest& request)
613613
throw std::runtime_error(
614614
"dumpwallet \"filename\"\n"
615615
"\nDumps all wallet keys in a human-readable format to a server-side file. This does not allow overwriting existing files.\n"
616-
"Imported scripts are not currently included in wallet dumps, these must be backed up separately.\n"
616+
"Imported scripts are included in the dumpfile, but corresponding BIP173 addresses, etc. may not be added automatically by importwallet.\n"
617617
"Note that if your wallet contains keys which are not derived from your HD seed (e.g. imported keys), these are not covered by\n"
618618
"only backing up the seed itself, and must be backed up too (e.g. ensure you back up the whole dumpfile).\n"
619619
"\nArguments:\n"

0 commit comments

Comments
 (0)