Skip to content

Commit 1bcd442

Browse files
Remove the virtual specifier for functions with the override specifier
`override` guarantees that the function is virtual (in addition to that the function is overriding a virtual function from a base class).
1 parent 929fd72 commit 1bcd442

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/dbwrapper.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class CBitcoinLevelDBLogger : public leveldb::Logger {
1919
public:
2020
// This code is adapted from posix_logger.h, which is why it is using vsprintf.
2121
// Please do not do this in normal code
22-
virtual void Logv(const char * format, va_list ap) override {
22+
void Logv(const char * format, va_list ap) override {
2323
if (!LogAcceptCategory(BCLog::LEVELDB)) {
2424
return;
2525
}

src/keystore.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,14 @@ class CBasicKeyStore : public CKeyStore
9797
}
9898
return false;
9999
}
100-
virtual bool AddCScript(const CScript& redeemScript) override;
101-
virtual bool HaveCScript(const CScriptID &hash) const override;
102-
virtual bool GetCScript(const CScriptID &hash, CScript& redeemScriptOut) const override;
100+
bool AddCScript(const CScript& redeemScript) override;
101+
bool HaveCScript(const CScriptID &hash) const override;
102+
bool GetCScript(const CScriptID &hash, CScript& redeemScriptOut) const override;
103103

104-
virtual bool AddWatchOnly(const CScript &dest) override;
105-
virtual bool RemoveWatchOnly(const CScript &dest) override;
106-
virtual bool HaveWatchOnly(const CScript &dest) const override;
107-
virtual bool HaveWatchOnly() const override;
104+
bool AddWatchOnly(const CScript &dest) override;
105+
bool RemoveWatchOnly(const CScript &dest) override;
106+
bool HaveWatchOnly(const CScript &dest) const override;
107+
bool HaveWatchOnly() const override;
108108
};
109109

110110
typedef std::vector<unsigned char, secure_allocator<unsigned char> > CKeyingMaterial;

0 commit comments

Comments
 (0)