Skip to content

Commit 1d22300

Browse files
committed
Address functional test nits
1 parent 5669642 commit 1d22300

File tree

1 file changed

+3
-3
lines changed
  • test/functional/test_framework

1 file changed

+3
-3
lines changed

test/functional/test_framework/key.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,8 @@ def set(self, data):
240240
x = int.from_bytes(data[1:33], 'big')
241241
if SECP256K1.is_x_coord(x):
242242
p = SECP256K1.lift_x(x)
243-
# if the oddness of the y co-ord isn't correct, find the other
244-
# valid y
243+
# Make the Y coordinate odd if required (lift_x always produces
244+
# a point with an even Y coordinate).
245245
if data[0] & 1:
246246
p = SECP256K1.negate(p)
247247
self.p = p
@@ -542,7 +542,7 @@ def test_schnorr_testvectors(self):
542542
sig_actual = sign_schnorr(seckey, msg, aux_rand)
543543
self.assertEqual(sig.hex(), sig_actual.hex(), "BIP340 test vector %i (%s): sig mismatch" % (i, comment))
544544
except RuntimeError as e:
545-
self.assertFalse("BIP340 test vector %i (%s): signing raised exception %s" % (i, comment, e))
545+
self.fail("BIP340 test vector %i (%s): signing raised exception %s" % (i, comment, e))
546546
result_actual = verify_schnorr(pubkey, sig, msg)
547547
if result:
548548
self.assertEqual(result, result_actual, "BIP340 test vector %i (%s): verification failed" % (i, comment))

0 commit comments

Comments
 (0)