setban: add RPCErrorCode

jonasschnelli · jonasschnelli · commit 1f02b802538f · 2015-06-17T21:40:56.000+02:00
diff --git a/src/rpcnet.cpp b/src/rpcnet.cpp
@@ -524,7 +524,7 @@ UniValue setban(const UniValue& params, bool fHelp)
     else if(strCommand == "remove")
     {
         if (!( isSubnet ? CNode::Unban(subNet) : CNode::Unban(netAddr) ))
-            throw JSONRPCError(RPC_CLIENT_NODE_ALREADY_ADDED, "Error: Unban failed");
+            throw JSONRPCError(RPC_MISC_ERROR, "Error: Unban failed");
     }
 
     return NullUniValue;
diff --git a/src/rpcprotocol.h b/src/rpcprotocol.h
@@ -64,6 +64,7 @@ enum RPCErrorCode
     RPC_CLIENT_NODE_ALREADY_ADDED   = -23, //! Node is already added
     RPC_CLIENT_NODE_NOT_ADDED       = -24, //! Node has not been added before
     RPC_CLIENT_NODE_NOT_CONNECTED   = -29, //! Node to disconnect not found in connected nodes
+    RPC_CLIENT_INVALID_IP_OR_SUBNET = -30, //! Invalid IP/Subnet
 
     //! Wallet errors
     RPC_WALLET_ERROR                = -4,  //! Unspecified problem with wallet (key not found etc.)

Original file line number	Diff line number	Diff line change
`@@ -524,7 +524,7 @@ UniValue setban(const UniValue& params, bool fHelp)`
`524`	`524`	`else if(strCommand == "remove")`
`525`	`525`	`{`
`526`	`526`	`if (!( isSubnet ? CNode::Unban(subNet) : CNode::Unban(netAddr) ))`
`527`		`- throw JSONRPCError(RPC_CLIENT_NODE_ALREADY_ADDED, "Error: Unban failed");`
	`527`	`+ throw JSONRPCError(RPC_MISC_ERROR, "Error: Unban failed");`
`528`	`528`	`}`
`529`	`529`
`530`	`530`	`return NullUniValue;`