Merge #19828: wallet, refactor: Remove duplicate map lookups in GetAddressBalances

fanquake · fanquake · commit 21eda43cdea8 · 2020-08-31T10:24:18.000+08:00
b35e74b wallet, refactor: Remove duplicate map lookups in GetAddressBalances (João Barbosa) Pull request description: Now just one lookup in `balances` instead of three. ACKs for top commit: achow101: ACK b35e74b theStack: ACK b35e74b practicalswift: ACK b35e74b Tree-SHA512: a73c1b336406a569e3bb10290618c5950b944db58ed0b05ff202d097684bb3ba3a5942c8d30443960052aa16438c054e2d02977b67aa901cce665c4df0ee5602
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -3372,9 +3372,6 @@ std::map<CTxDestination, CAmount> CWallet::GetAddressBalances() const
                     continue;
 
                 CAmount n = IsSpent(walletEntry.first, i) ? 0 : wtx.tx->vout[i].nValue;
-
-                if (!balances.count(addr))
-                    balances[addr] = 0;
                 balances[addr] += n;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -3372,9 +3372,6 @@ std::map<CTxDestination, CAmount> CWallet::GetAddressBalances() const`
`3372`	`3372`	`continue;`
`3373`	`3373`
`3374`	`3374`	`CAmount n = IsSpent(walletEntry.first, i) ? 0 : wtx.tx->vout[i].nValue;`
`3375`		`-`
`3376`		`- if (!balances.count(addr))`
`3377`		`- balances[addr] = 0;`
`3378`	`3375`	`balances[addr] += n;`
`3379`	`3376`	`}`
`3380`	`3377`	`}`