Skip to content

Commit 22fa967

Browse files
author
MarcoFalke
committed
Merge #20917: doc, rpc: add missing signet mentions in network name lists
fc726e0 doc, rpc: add missing signet mentions in network name lists (Sebastian Falbesoner) Pull request description: This small PR adds a few missing mentions of signet w.r.t. chain enumerations: - RPC `getblockchaininfo`: result description for `"chain"` - RPC `getmininginfo`: result description for `"chain"` - REST interface documentation: - default ports listing for each chain - `"chain"` description for `chaininfo` endpoint result The instances were identified via `git grep -i "main.*test.*reg"`. ACKs for top commit: ajtowns: ACK fc726e0 -- quick code review only benthecarman: ACK fc726e0 Tree-SHA512: 62cdc6ef74fa10db75cc04b9eaf7367183f726b3fee3d21fdf741b3816669dd21508735e89da389ddac980f49773ab229263748d1399553375fefe4526361846
2 parents e7eb371 + fc726e0 commit 22fa967

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

doc/REST-interface.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Unauthenticated REST Interface
44
The REST API can be enabled with the `-rest` option.
55

66
The interface runs on the same port as the JSON-RPC interface, by default port 8332 for mainnet, port 18332 for testnet,
7-
and port 18443 for regtest.
7+
port 38332 for signet, and port 18443 for regtest.
88

99
REST Interface consistency guarantees
1010
-------------------------------------
@@ -62,7 +62,7 @@ Given a height: returns hash of block in best-block-chain at height provided.
6262

6363
Returns various state info regarding block chain processing.
6464
Only supports JSON as output format.
65-
* chain : (string) current network name (main, test, regtest)
65+
* chain : (string) current network name (main, test, signet, regtest)
6666
* blocks : (numeric) the current number of blocks processed in the server
6767
* headers : (numeric) the current number of headers we have validated
6868
* bestblockhash : (string) the hash of the currently best block

src/rpc/blockchain.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1283,7 +1283,7 @@ RPCHelpMan getblockchaininfo()
12831283
RPCResult{
12841284
RPCResult::Type::OBJ, "", "",
12851285
{
1286-
{RPCResult::Type::STR, "chain", "current network name (main, test, regtest)"},
1286+
{RPCResult::Type::STR, "chain", "current network name (main, test, signet, regtest)"},
12871287
{RPCResult::Type::NUM, "blocks", "the height of the most-work fully-validated chain. The genesis block has height 0"},
12881288
{RPCResult::Type::NUM, "headers", "the current number of headers we have validated"},
12891289
{RPCResult::Type::STR, "bestblockhash", "the hash of the currently best block"},

src/rpc/mining.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ static RPCHelpMan getmininginfo()
409409
{RPCResult::Type::NUM, "difficulty", "The current difficulty"},
410410
{RPCResult::Type::NUM, "networkhashps", "The network hashes per second"},
411411
{RPCResult::Type::NUM, "pooledtx", "The size of the mempool"},
412-
{RPCResult::Type::STR, "chain", "current network name (main, test, regtest)"},
412+
{RPCResult::Type::STR, "chain", "current network name (main, test, signet, regtest)"},
413413
{RPCResult::Type::STR, "warnings", "any network and blockchain warnings"},
414414
}},
415415
RPCExamples{

0 commit comments

Comments
 (0)