Merge #18563: test: Fix unregister_all_during_call cleanup

13d2a33 Fix unregister_all_during_call cleanup (Russell Yanofsky)

Pull request description:

  Use `TestingSetup` fixture to fix `unregister_all_during_call` test not calling `UnregisterBackgroundSignalScheduler`, which could trigger an assert in `RegisterBackgroundSignalScheduler` when called in later tests

  Failure reported by fanquake bitcoin/bitcoin#18551 (comment)

ACKs for top commit:
  MarcoFalke:
    ACK 13d2a33 if appveyor unit tests pass

Tree-SHA512: d2ec8ff14c54d97903af50031abfac1f38ec1c3aabc90371cfd5b79481fa69d3d77f339bfdf7d2178fd85e83402f72eda7cf4d339e5bbfa7e6e1a68836643b93

Author: MarcoFalke

src/test/validationinterface_tests.cpp

@@ -3,14 +3,14 @@
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
 #include <boost/test/unit_test.hpp>
-
 #include <consensus/validation.h>
 #include <primitives/block.h>
 #include <scheduler.h>
+#include <test/util/setup_common.h>
 #include <util/check.h>
 #include <validationinterface.h>
 
-BOOST_AUTO_TEST_SUITE(validationinterface_tests)
+BOOST_FIXTURE_TEST_SUITE(validationinterface_tests, TestingSetup)
 
 class TestInterface : public CValidationInterface
 {
@@ -43,9 +43,6 @@ class TestInterface : public CValidationInterface
 BOOST_AUTO_TEST_CASE(unregister_all_during_call)
 {
     bool destroyed = false;
-
-    CScheduler scheduler;
-    GetMainSignals().RegisterBackgroundSignalScheduler(scheduler);
     RegisterSharedValidationInterface(std::make_shared<TestInterface>(
         [&] {
             // First call should decrements reference count 2 -> 1