bitcoin-tx: rbfoptin: Avoid touching nSequence if the value is already opting in

luke-jr · luke-jr · commit 23b0fe34f526 · 2017-06-05T23:14:34.000Z
diff --git a/src/bitcoin-tx.cpp b/src/bitcoin-tx.cpp
@@ -216,7 +216,9 @@ static void MutateTxRBFOptIn(CMutableTransaction& tx, const std::string& strInId
     int cnt = 0;
     for (CTxIn& txin : tx.vin) {
         if (strInIdx == "" || cnt == inIdx) {
-            txin.nSequence = MAX_BIP125_RBF_SEQUENCE;
+            if (txin.nSequence > MAX_BIP125_RBF_SEQUENCE) {
+                txin.nSequence = MAX_BIP125_RBF_SEQUENCE;
+            }
         }
         ++cnt;
     }

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,9 @@ static void MutateTxRBFOptIn(CMutableTransaction& tx, const std::string& strInId`
`216`	`216`	`int cnt = 0;`
`217`	`217`	`for (CTxIn& txin : tx.vin) {`
`218`	`218`	`if (strInIdx == "" \|\| cnt == inIdx) {`
`219`		`- txin.nSequence = MAX_BIP125_RBF_SEQUENCE;`
	`219`	`+ if (txin.nSequence > MAX_BIP125_RBF_SEQUENCE) {`
	`220`	`+ txin.nSequence = MAX_BIP125_RBF_SEQUENCE;`
	`221`	`+ }`
`220`	`222`	`}`
`221`	`223`	`++cnt;`
`222`	`224`	`}`