Merge #20731: rpc: Add missing description of vout in getrawtransaction help text

MarcoFalke · MarcoFalke · commit 2556a973ed58 · 2020-12-21T19:57:38.000+01:00
b23349b rpc: Add missing description of vout in getrawtransaction help text (Ben Carman) Pull request description: In `getrawtransaction` the vout did not have a description. I gave it the same description as the one used in `decoderawtransaction`. ACKs for top commit: MarcoFalke: ACK b23349b 🏯 Tree-SHA512: 3833b97c82a46dfeb7ac825d4b2514b4b05ce54ac41f2144a8e2f2093b3411fe1d090c1e5b0c3d09200a2ea164c8d17ece12cdb43bbaeaeccc51a9da6dd7b7a3
diff --git a/src/rpc/rawtransaction.cpp b/src/rpc/rawtransaction.cpp
@@ -109,7 +109,7 @@ static RPCHelpMan getrawtransaction()
                                  {RPCResult::Type::OBJ, "", "",
                                  {
                                      {RPCResult::Type::STR_HEX, "txid", "The transaction id"},
-                                     {RPCResult::Type::STR, "vout", ""},
+                                     {RPCResult::Type::NUM, "vout", "The output number"},
                                      {RPCResult::Type::OBJ, "scriptSig", "The script",
                                      {
                                          {RPCResult::Type::STR, "asm", "asm"},

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ static RPCHelpMan getrawtransaction()`
`109`	`109`	`{RPCResult::Type::OBJ, "", "",`
`110`	`110`	`{`
`111`	`111`	`{RPCResult::Type::STR_HEX, "txid", "The transaction id"},`
`112`		`- {RPCResult::Type::STR, "vout", ""},`
	`112`	`+ {RPCResult::Type::NUM, "vout", "The output number"},`
`113`	`113`	`{RPCResult::Type::OBJ, "scriptSig", "The script",`
`114`	`114`	`{`
`115`	`115`	`{RPCResult::Type::STR, "asm", "asm"},`