Merge #18459: rpc: remove unused getbalances() code

MarcoFalke · MarcoFalke · commit 27a82d347edd · 2020-03-28T17:09:52.000-04:00
6e0d82c rpc: remove unused getbalances() code (Jon Atack) Pull request description: This line from 999931c appears to be extraneous and replaced 2 lines after by `UniValue balances{UniValue::VOBJ};`. ACKs for top commit: Empact: ACK bitcoin/bitcoin@6e0d82c hebasto: ACK 6e0d82c, the `obj` local variable is not used until the end of the scope. Tree-SHA512: a220ca9cda091e78144d9b7fbe4bf90e8338d6e8c8dc7bea27a8e62f3a8ac1d983ad12a48a0a3366b2d8b9586878dfc69c1ec34bf846b34c91e42cda48a59850
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -2390,8 +2390,6 @@ static UniValue getbalances(const JSONRPCRequest& request)
     auto locked_chain = wallet.chain().lock();
     LOCK(wallet.cs_wallet);
 
-    UniValue obj(UniValue::VOBJ);
-
     const auto bal = wallet.GetBalance();
     UniValue balances{UniValue::VOBJ};
     {

Original file line number	Diff line number	Diff line change
`@@ -2390,8 +2390,6 @@ static UniValue getbalances(const JSONRPCRequest& request)`
`2390`	`2390`	`auto locked_chain = wallet.chain().lock();`
`2391`	`2391`	`LOCK(wallet.cs_wallet);`
`2392`	`2392`
`2393`		`- UniValue obj(UniValue::VOBJ);`
`2394`		`-`
`2395`	`2393`	`const auto bal = wallet.GetBalance();`
`2396`	`2394`	`UniValue balances{UniValue::VOBJ};`
`2397`	`2395`	`{`