Skip to content

Commit 27e63e0

Browse files
committed
build: Accomodate makensis v2.x
Apparently the -X flag doesn't work as expected in makensis v2.x For example: makensis -V2 share/setup.nsi -X'OutFile "test.exe"' Will output: OutFile expects 1 parameters, got 0. Usage: OutFile install_output.exe So let's instead construct the file using POSIX-compliant commands and shell constructs
1 parent 1f2c39a commit 27e63e0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ $(BITCOIN_WIN_INSTALLER): all-recursive
8080
STRIPPROG="$(STRIP)" $(INSTALL_STRIP_PROGRAM) $(BITCOIN_CLI_BIN) $(top_builddir)/release
8181
STRIPPROG="$(STRIP)" $(INSTALL_STRIP_PROGRAM) $(BITCOIN_TX_BIN) $(top_builddir)/release
8282
STRIPPROG="$(STRIP)" $(INSTALL_STRIP_PROGRAM) $(BITCOIN_WALLET_BIN) $(top_builddir)/release
83-
@test -f $(MAKENSIS) && $(MAKENSIS) -V2 $(top_builddir)/share/setup.nsi -X'OutFile "$@"' || \
83+
@test -f $(MAKENSIS) && echo 'OutFile "$@"' | cat $(top_builddir)/share/setup.nsi - | $(MAKENSIS) -V2 - || \
8484
echo error: could not build $@
8585
@echo built $@
8686

0 commit comments

Comments
 (0)