Skip to content

Commit 297cc20

Browse files
committed
qt: layoutAboutToChange signal is called layoutAboutToBeChanged
This was misnamed, resulting in a warning message and missing functionality. I'm not sure what the change in behavior will be here, this needs testing. Also remove connection to non-existing slot "test". This was used for testing if the signal arrived. It is no longer necessary. Fixes: 2016-12-01 10:04:06 GUI: QObject::connect: No such signal PeerTableModel::layoutAboutToChange() in qt/rpcconsole.cpp:518 2016-12-01 10:04:06 GUI: QObject::connect: (receiver name: 'RPCConsole') 2016-12-01 10:04:06 GUI: QObject::connect: No such slot RPCConsole::test() in qt/rpcconsole.cpp:781 2016-12-01 10:04:06 GUI: QObject::connect: (receiver name: 'RPCConsole')
1 parent 3bf06e9 commit 297cc20

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/qt/rpcconsole.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -515,7 +515,7 @@ void RPCConsole::setClientModel(ClientModel *model)
515515
// peer table signal handling - update peer details when new nodes are added to the model
516516
connect(model->getPeerTableModel(), SIGNAL(layoutChanged()), this, SLOT(peerLayoutChanged()));
517517
// peer table signal handling - cache selected node ids
518-
connect(model->getPeerTableModel(), SIGNAL(layoutAboutToChange()), this, SLOT(peerLayoutAboutToChange()));
518+
connect(model->getPeerTableModel(), SIGNAL(layoutAboutToBeChanged()), this, SLOT(peerLayoutAboutToChange()));
519519

520520
// set up ban table
521521
ui->banlistWidget->setModel(model->getBanTableModel());
@@ -778,7 +778,6 @@ void RPCConsole::startExecutor()
778778
connect(this, SIGNAL(stopExecutor()), &thread, SLOT(quit()));
779779
// - queue executor for deletion (in execution thread)
780780
connect(&thread, SIGNAL(finished()), executor, SLOT(deleteLater()), Qt::DirectConnection);
781-
connect(&thread, SIGNAL(finished()), this, SLOT(test()), Qt::DirectConnection);
782781

783782
// Default implementation of QThread::run() simply spins up an event loop in the thread,
784783
// which is what we want.

0 commit comments

Comments
 (0)