Skip to content

Commit 2a492d4

Browse files
committed
Merge bitcoin/bitcoin#23598: contrib: Specify wb mode when creating mac sdk
655d52a contrib: Specify wb mode when creating mac sdk (João Barbosa) Pull request description: Fix the warning: ``` ./contrib/macdeploy/gen-sdk:84: FutureWarning: GzipFile was opened for writing, but this will change in future Python releases. Specify the mode argument for opening it for writing. ``` ACKs for top commit: fanquake: Tested ACK 655d52a with Python 3.10. Tree-SHA512: 095cd301f211531a8b8f50e7915fe13c7ab0b278fb23dc50a03625cfae9e2fd7a0d8c315fced4af3011552e3e455ce562b7f717a0ed096c4433ddcf24f22b2c9
2 parents 16d698c + 655d52a commit 2a492d4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

contrib/macdeploy/gen-sdk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def run():
8181

8282
print("Creating output .tar.gz file...")
8383
with out_sdktgz_path.open("wb") as fp:
84-
with gzip.GzipFile(fileobj=fp, compresslevel=9, mtime=0) as gzf:
84+
with gzip.GzipFile(fileobj=fp, mode='wb', compresslevel=9, mtime=0) as gzf:
8585
with tarfile.open(mode="w", fileobj=gzf) as tarfp:
8686
print("Adding MacOSX SDK {} files...".format(sdk_version))
8787
tarfp_add_with_base_change(tarfp, sdk_dir, out_name)

0 commit comments

Comments
 (0)