You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: doc/developer-notes.md
+18-14Lines changed: 18 additions & 14 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -963,37 +963,41 @@ Subtrees
963
963
964
964
Several parts of the repository are subtrees of software maintained elsewhere.
965
965
966
-
Some of these are maintained by active developers of Bitcoin Core, in which case changes should probably go
967
-
directly upstream without being PRed directly against the project. They will be merged back in the next
968
-
subtree merge.
966
+
Some of these are maintained by active developers of Bitcoin Core, in which case
967
+
changes should go directly upstream without being PRed directly against the project.
968
+
They will be merged back in the next subtree merge.
969
969
970
-
Others are external projects without a tight relationship with our project. Changes to these should also
971
-
be sent upstream, but bugfixes may also be prudent to PR against Bitcoin Core so that they can be integrated
972
-
quickly. Cosmetic changes should be purely taken upstream.
970
+
Others are external projects without a tight relationship with our project. Changes
971
+
to these should also be sent upstream, but bugfixes may also be prudent to PR against
972
+
a Bitcoin Core subtree, so that they can be integrated quickly. Cosmetic changes
973
+
should be taken upstream.
973
974
974
-
There is a tool in `test/lint/git-subtree-check.sh` ([instructions](../test/lint#git-subtree-checksh)) to check a subtree directory for consistency with
975
-
its upstream repository.
975
+
There is a tool in `test/lint/git-subtree-check.sh` ([instructions](../test/lint#git-subtree-checksh))
976
+
to check a subtree directory for consistency with its upstream repository.
976
977
977
978
Current subtrees include:
978
979
979
980
- src/leveldb
980
-
- Upstream at https://github.com/google/leveldb ; Maintained by Google, but
981
-
open important PRs to Core to avoid delay.
981
+
- Subtree at https://github.com/bitcoin-core/leveldb-subtree ; maintained by Core contributors.
982
+
- Upstream at https://github.com/google/leveldb ; maintained by Google. Open
983
+
important PRs to the subtree to avoid delay.
982
984
-**Note**: Follow the instructions in [Upgrading LevelDB](#upgrading-leveldb) when
983
985
merging upstream changes to the LevelDB subtree.
984
986
985
987
- src/crc32c
986
988
- Used by leveldb for hardware acceleration of CRC32C checksums for data integrity.
987
-
- Upstream at https://github.com/google/crc32c ; Maintained by Google.
989
+
- Subtree at https://github.com/bitcoin-core/crc32c-subtree ; maintained by Core contributors.
990
+
- Upstream at https://github.com/google/crc32c ; maintained by Google.
988
991
989
992
- src/secp256k1
990
-
- Upstream at https://github.com/bitcoin-core/secp256k1/ ; actively maintained by Core contributors.
993
+
- Upstream at https://github.com/bitcoin-core/secp256k1/ ; maintained by Core contributors.
991
994
992
995
- src/crypto/ctaes
993
-
- Upstream at https://github.com/bitcoin-core/ctaes ; actively maintained by Core contributors.
996
+
- Upstream at https://github.com/bitcoin-core/ctaes ; maintained by Core contributors.
994
997
995
998
- src/univalue
996
-
- Upstream at https://github.com/bitcoin-core/univalue ; actively maintained by Core contributors, deviates from upstream https://github.com/jgarzik/univalue
999
+
- Subtree at https://github.com/bitcoin-core/univalue-subtree ; maintained by Core contributors.
1000
+
- Deviates from upstream https://github.com/jgarzik/univalue.
0 commit comments