Skip to content

Commit 2f629f8

Browse files
committed
contrib: Remove suspicious hosts list from makeseeds
I have some qualms with maintaining a suspicious hosts list as part as the repository. But also, it's stale and irrelevant. I've checked the entire list and none of them is connectable. Only one still appars in `nodes_main.txt` but with low uptime and an old subversion string so it wouldn't be picked in the first place.
1 parent f3e0ace commit 2f629f8

File tree

2 files changed

+0
-25
lines changed

2 files changed

+0
-25
lines changed

contrib/seeds/makeseeds.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,6 @@
2121

2222
MIN_BLOCKS = 730000
2323

24-
# These are hosts that have been observed to be behaving strangely (e.g.
25-
# aggressively connecting to every node).
26-
with open("suspicious_hosts.txt", mode="r", encoding="utf-8") as f:
27-
SUSPICIOUS_HOSTS = {s.strip() for s in f if s.strip()}
28-
29-
3024
PATTERN_IPV4 = re.compile(r"^((\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})):(\d+)$")
3125
PATTERN_IPV6 = re.compile(r"^\[([0-9a-z:]+)\]:(\d+)$")
3226
PATTERN_ONION = re.compile(r"^([a-z2-7]{56}\.onion):(\d+)$")
@@ -213,9 +207,6 @@ def main():
213207
# Skip duplicates (in case multiple seeds files were concatenated)
214208
ips = dedup(ips)
215209
print(f'{ip_stats(ips):s} After removing duplicates', file=sys.stderr)
216-
# Skip entries from suspicious hosts.
217-
ips = [ip for ip in ips if ip['ip'] not in SUSPICIOUS_HOSTS]
218-
print(f'{ip_stats(ips):s} Skip entries from suspicious hosts', file=sys.stderr)
219210
# Enforce minimal number of blocks.
220211
ips = [ip for ip in ips if ip['blocks'] >= MIN_BLOCKS]
221212
print(f'{ip_stats(ips):s} Enforce minimal number of blocks', file=sys.stderr)

contrib/seeds/suspicious_hosts.txt

Lines changed: 0 additions & 16 deletions
This file was deleted.

0 commit comments

Comments
 (0)