Skip to content

Commit 33a53bc

Browse files
Jeff GarzikJeff Garzik
authored andcommitted
CTxMemPool::accept(): do not log FetchInputs failure redundantly
FetchInputs already logs failures internally. This commit makes the logging more consistent with other FetchInputs callsites also. Prior to this commit, two log lines were logged for one condition: ERROR: FetchInputs() : de15fde415 mempool Tx prev not found a2c75da227 ERROR: CTxMemPool::accept() : FetchInputs failed de15fde415 After this commit, only one line is logged: ERROR: FetchInputs() : e0507ab2c7 mempool Tx prev not found 9a620262cd
1 parent 133dce6 commit 33a53bc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ bool CTxMemPool::accept(CTxDB& txdb, CTransaction &tx, bool fCheckInputs,
527527
return error("CTxMemPool::accept() : FetchInputs found invalid tx %s", hash.ToString().substr(0,10).c_str());
528528
if (pfMissingInputs)
529529
*pfMissingInputs = true;
530-
return error("CTxMemPool::accept() : FetchInputs failed %s", hash.ToString().substr(0,10).c_str());
530+
return false;
531531
}
532532

533533
// Check for non-standard pay-to-script-hash in inputs

0 commit comments

Comments
 (0)