Skip to content

Commit 36f60a5

Browse files
committed
Add copyright/patent issues to possible NACK reasons
Adding in response to a Slack discussion where someone was unclear on the fact that a NACK may be justified if code can't be accepted due to copyright/patent issues. For example, it would be reasonable and prudent to NACK a contribution of AGPL-licensed consensus code on the basis that the license terms are incompatible with the MIT license used by the rest of the codebase.
1 parent e2b8c39 commit 36f60a5

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,9 @@ language is used within pull-request comments:
178178

179179
- ACK means "I have tested the code and I agree it should be merged";
180180
- NACK means "I disagree this should be merged", and must be accompanied by
181-
sound technical justification. NACKs without accompanying reasoning may be disregarded;
181+
sound technical justification (or in certain cases of copyright/patent/licensing
182+
issues, legal justification). NACKs without accompanying reasoning may be
183+
disregarded;
182184
- utACK means "I have not tested the code, but I have reviewed it and it looks
183185
OK, I agree it can be merged";
184186
- Concept ACK means "I agree in the general principle of this pull request";

0 commit comments

Comments
 (0)