Skip to content

Commit 391a273

Browse files
author
MarcoFalke
committed
Merge #15173: [doc] explain what .python-version does
04215eb [doc] explain what .python-version does (Sjors Provoost) Pull request description: Documentation followup to bitcoin/bitcoin#14884 (comment). Tree-SHA512: 7b2b2718f998b7257273fab2e4f1d127f7af468cd26b2bf05b3dc7d6367e349e0a9c92e976a2760e83cf56feb68c37c89cb3a8d92e20be900bea3fb7f1f3d47b
2 parents c7c8420 + 04215eb commit 391a273

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

test/functional/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ don't have test cases for.
2020
- Where possible, try to adhere to [PEP-8 guidelines](https://www.python.org/dev/peps/pep-0008/)
2121
- Use a python linter like flake8 before submitting PRs to catch common style
2222
nits (eg trailing whitespace, unused imports, etc)
23+
- The oldest supported Python version is specified in [doc/dependencies.md](/doc/dependencies.md).
24+
Consider using [pyenv](https://github.com/pyenv/pyenv), which checks [.python-version](/.python-version),
25+
to prevent accidentally introducing modern syntax from an unsupported Python version.
26+
The Travis linter also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126).
2327
- See [the python lint script](/test/lint/lint-python.sh) that checks for violations that
2428
could lead to bugs and issues in the test code.
2529
- Avoid wildcard imports where possible

0 commit comments

Comments
 (0)