Skip to content

Commit 397c6d3

Browse files
author
MarcoFalke
committed
Merge #17503: doc: Remove bitness from bitcoin-qt help message and manpage
e161bc7 doc: Remove bitness from bitcoin-qt help message and manpage (Wladimir J. van der Laan) Pull request description: Remove the `(64-bit)` from the bitcoin-qt help message. Since removing the Windows 32-bit builds, it is no longer information that is often useful for troubleshooting. This never worked for other architectures than x86, and the only 32-bit x86 build left is the Linux one. Linux users tend to know what architecture they are using. It also accidentally ends up in the bitcoin-qt manpage (if you happen to be generating them on a x86 machine), which gets checked in. See for example bitcoin/bitcoin@1bc9988#diff-e4b84be382c8ea33b83203ceb8c85296 ACKs for top commit: practicalswift: ACK e161bc7 -- rationale makes sense and diff looks correct :) MarcoFalke: Tested ACK e161bc7 🔮 Tree-SHA512: d38754903252896dc86fac6c12ad6615d322c2744db7c02b18574a08c69e8876b2c905e1f09b324002236b111ee93479f89769c562e7b3b2e6eb2992d76464ef
2 parents 6fde676 + e161bc7 commit 397c6d3

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

src/qt/utilitydialog.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,6 @@ HelpMessageDialog::HelpMessageDialog(interfaces::Node& node, QWidget *parent, bo
3434
ui->setupUi(this);
3535

3636
QString version = QString{PACKAGE_NAME} + " " + tr("version") + " " + QString::fromStdString(FormatFullVersion());
37-
/* On x86 add a bit specifier to the version so that users can distinguish between
38-
* 32 and 64 bit builds. On other architectures, 32/64 bit may be more ambiguous.
39-
*/
40-
#if defined(__x86_64__)
41-
version += " " + tr("(%1-bit)").arg(64);
42-
#elif defined(__i386__ )
43-
version += " " + tr("(%1-bit)").arg(32);
44-
#endif
4537

4638
if (about)
4739
{

0 commit comments

Comments
 (0)