Skip to content

Commit 3ac7060

Browse files
committed
Merge pull request #6978
69d0513 build: Use fPIC rather than fPIE for qt objects. (Cory Fields) 17c4d9d build: Split hardening/fPIE options out (Cory Fields)
2 parents cb841e7 + 69d0513 commit 3ac7060

File tree

7 files changed

+93
-27
lines changed

7 files changed

+93
-27
lines changed

build-aux/m4/bitcoin_qt.m4

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,9 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
106106
dnl results to QT_LIBS.
107107
BITCOIN_QT_CHECK([
108108
TEMP_CPPFLAGS=$CPPFLAGS
109+
TEMP_CXXFLAGS=$CXXFLAGS
109110
CPPFLAGS="$QT_INCLUDES $CPPFLAGS"
111+
CXXFLAGS="$PIC_FLAGS $CXXFLAGS"
110112
if test x$bitcoin_qt_got_major_vers = x5; then
111113
_BITCOIN_QT_IS_STATIC
112114
if test x$bitcoin_cv_static_qt = xyes; then
@@ -149,6 +151,7 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
149151
fi
150152
fi
151153
CPPFLAGS=$TEMP_CPPFLAGS
154+
CXXFLAGS=$TEMP_CXXFLAGS
152155
])
153156
154157
if test x$use_pkgconfig$qt_bin_path = xyes; then
@@ -157,6 +160,43 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
157160
fi
158161
fi
159162
163+
if test x$use_hardening != xno; then
164+
BITCOIN_QT_CHECK([
165+
AC_MSG_CHECKING(whether -fPIE can be used with this Qt config)
166+
TEMP_CPPFLAGS=$CPPFLAGS
167+
TEMP_CXXFLAGS=$CXXFLAGS
168+
CPPFLAGS="$QT_INCLUDES $CPPFLAGS"
169+
CXXFLAGS="$PIE_FLAGS $CXXFLAGS"
170+
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <QtCore/qconfig.h>]],
171+
[[
172+
#if defined(QT_REDUCE_RELOCATIONS)
173+
choke;
174+
#endif
175+
]])],
176+
[ AC_MSG_RESULT(yes); QT_PIE_FLAGS=$PIE_FLAGS ],
177+
[ AC_MSG_RESULT(no); QT_PIE_FLAGS=$PIC_FLAGS]
178+
)
179+
CPPFLAGS=$TEMP_CPPFLAGS
180+
CXXFLAGS=$TEMP_CXXFLAGS
181+
])
182+
else
183+
BITCOIN_QT_CHECK([
184+
AC_MSG_CHECKING(whether -fPIC is needed with this Qt config)
185+
TEMP_CPPFLAGS=$CPPFLAGS
186+
CPPFLAGS="$QT_INCLUDES $CPPFLAGS"
187+
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <QtCore/qconfig.h>]],
188+
[[
189+
#if defined(QT_REDUCE_RELOCATIONS)
190+
choke;
191+
#endif
192+
]])],
193+
[ AC_MSG_RESULT(no)],
194+
[ AC_MSG_RESULT(yes); QT_PIE_FLAGS=$PIC_FLAGS]
195+
)
196+
CPPFLAGS=$TEMP_CPPFLAGS
197+
])
198+
fi
199+
160200
BITCOIN_QT_PATH_PROGS([MOC], [moc-qt${bitcoin_qt_got_major_vers} moc${bitcoin_qt_got_major_vers} moc], $qt_bin_path)
161201
BITCOIN_QT_PATH_PROGS([UIC], [uic-qt${bitcoin_qt_got_major_vers} uic${bitcoin_qt_got_major_vers} uic], $qt_bin_path)
162202
BITCOIN_QT_PATH_PROGS([RCC], [rcc-qt${bitcoin_qt_got_major_vers} rcc${bitcoin_qt_got_major_vers} rcc], $qt_bin_path)
@@ -202,6 +242,7 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
202242
])
203243
AC_MSG_RESULT([$bitcoin_enable_qt (Qt${bitcoin_qt_got_major_vers})])
204244
245+
AC_SUBST(QT_PIE_FLAGS)
205246
AC_SUBST(QT_INCLUDES)
206247
AC_SUBST(QT_LIBS)
207248
AC_SUBST(QT_LDFLAGS)
@@ -373,6 +414,8 @@ dnl Outputs: bitcoin_qt_got_major_vers is set to "4" or "5".
373414
dnl Outputs: have_qt_test and have_qt_dbus are set (if applicable) to yes|no.
374415
AC_DEFUN([_BITCOIN_QT_FIND_LIBS_WITHOUT_PKGCONFIG],[
375416
TEMP_CPPFLAGS="$CPPFLAGS"
417+
TEMP_CXXFLAGS="$CXXFLAGS"
418+
CXXFLAGS="$PIC_FLAGS $CXXFLAGS"
376419
TEMP_LIBS="$LIBS"
377420
BITCOIN_QT_CHECK([
378421
if test x$qt_include_path != x; then
@@ -442,6 +485,7 @@ AC_DEFUN([_BITCOIN_QT_FIND_LIBS_WITHOUT_PKGCONFIG],[
442485
fi
443486
])
444487
CPPFLAGS="$TEMP_CPPFLAGS"
488+
CXXFLAGS="$TEMP_CXXFLAGS"
445489
LIBS="$TEMP_LIBS"
446490
])
447491

configure.ac

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,7 @@ case $host in
326326

327327
AX_CHECK_LINK_FLAG([[-Wl,-headerpad_max_install_names]], [LDFLAGS="$LDFLAGS -Wl,-headerpad_max_install_names"])
328328
CPPFLAGS="$CPPFLAGS -DMAC_OSX"
329+
OBJCXXFLAGS="$CXXFLAGS"
329330
;;
330331
*linux*)
331332
TARGET_OS=linux
@@ -424,6 +425,11 @@ if test x$use_glibc_compat != xno; then
424425

425426
fi
426427

428+
if test x$TARGET_OS != xwindows; then
429+
# All windows code is PIC, forcing it on just adds useless compile warnings
430+
AX_CHECK_COMPILE_FLAG([-fPIC],[PIC_FLAGS="-fPIC"])
431+
fi
432+
427433
if test x$use_hardening != xno; then
428434
AX_CHECK_COMPILE_FLAG([-Wstack-protector],[HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -Wstack-protector"])
429435
AX_CHECK_COMPILE_FLAG([-fstack-protector-all],[HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -fstack-protector-all"])
@@ -441,8 +447,7 @@ if test x$use_hardening != xno; then
441447
AX_CHECK_LINK_FLAG([[-Wl,-z,now]], [HARDENED_LDFLAGS="$HARDENED_LDFLAGS -Wl,-z,now"])
442448

443449
if test x$TARGET_OS != xwindows; then
444-
# All windows code is PIC, forcing it on just adds useless compile warnings
445-
AX_CHECK_COMPILE_FLAG([-fPIE],[HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -fPIE"])
450+
AX_CHECK_COMPILE_FLAG([-fPIE],[PIE_FLAGS="-fPIE"])
446451
AX_CHECK_LINK_FLAG([[-pie]], [HARDENED_LDFLAGS="$HARDENED_LDFLAGS -pie"])
447452
fi
448453

@@ -451,11 +456,6 @@ if test x$use_hardening != xno; then
451456
AC_CHECK_LIB([ssp], [main],, AC_MSG_ERROR(lib missing))
452457
;;
453458
esac
454-
455-
CXXFLAGS="$CXXFLAGS $HARDENED_CXXFLAGS"
456-
CPPFLAGS="$CPPFLAGS $HARDENED_CPPFLAGS"
457-
LDFLAGS="$LDFLAGS $HARDENED_LDFLAGS"
458-
OBJCXXFLAGS="$CXXFLAGS"
459459
fi
460460

461461
dnl this flag screws up non-darwin gcc even when the check fails. special-case it.
@@ -915,6 +915,11 @@ AC_SUBST(CLIENT_VERSION_IS_RELEASE, _CLIENT_VERSION_IS_RELEASE)
915915
AC_SUBST(COPYRIGHT_YEAR, _COPYRIGHT_YEAR)
916916

917917
AC_SUBST(RELDFLAGS)
918+
AC_SUBST(HARDENED_CXXFLAGS)
919+
AC_SUBST(HARDENED_CPPFLAGS)
920+
AC_SUBST(HARDENED_LDFLAGS)
921+
AC_SUBST(PIC_FLAGS)
922+
AC_SUBST(PIE_FLAGS)
918923
AC_SUBST(LIBTOOL_APP_LDFLAGS)
919924
AC_SUBST(USE_UPNP)
920925
AC_SUBST(USE_QRCODE)

src/Makefile.am

Lines changed: 27 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
DIST_SUBDIRS = secp256k1 univalue
2-
AM_LDFLAGS = $(PTHREAD_CFLAGS) $(LIBTOOL_LDFLAGS)
32

3+
AM_LDFLAGS = $(PTHREAD_CFLAGS) $(LIBTOOL_LDFLAGS) $(HARDENED_LDFLAGS)
4+
AM_CXXFLAGS = $(HARDENED_CXXFLAGS)
5+
AM_CPPFLAGS = $(HARDENED_CPPFLAGS)
46

57
if EMBEDDED_LEVELDB
68
LEVELDB_CPPFLAGS += -I$(srcdir)/leveldb/include
@@ -14,7 +16,7 @@ $(LIBLEVELDB): $(LIBMEMENV)
1416
$(LIBLEVELDB) $(LIBMEMENV):
1517
@echo "Building LevelDB ..." && $(MAKE) -C $(@D) $(@F) CXX="$(CXX)" \
1618
CC="$(CC)" PLATFORM=$(TARGET_OS) AR="$(AR)" $(LEVELDB_TARGET_FLAGS) \
17-
OPT="$(CXXFLAGS) $(CPPFLAGS) -D__STDC_LIMIT_MACROS"
19+
OPT="$(AM_CXXFLAGS) $(PIE_FLAGS) $(CXXFLAGS) $(AM_CPPFLAGS) $(CPPFLAGS) -D__STDC_LIMIT_MACROS"
1820
endif
1921

2022
BITCOIN_CONFIG_INCLUDES=-I$(builddir)/config
@@ -178,7 +180,8 @@ obj/build.h: FORCE
178180
libbitcoin_util_a-clientversion.$(OBJEXT): obj/build.h
179181

180182
# server: shared between bitcoind and bitcoin-qt
181-
libbitcoin_server_a_CPPFLAGS = $(BITCOIN_INCLUDES) $(MINIUPNPC_CPPFLAGS) $(EVENT_CFLAGS) $(EVENT_PTHREADS_CFLAGS)
183+
libbitcoin_server_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) $(MINIUPNPC_CPPFLAGS) $(EVENT_CFLAGS) $(EVENT_PTHREADS_CFLAGS)
184+
libbitcoin_server_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
182185
libbitcoin_server_a_SOURCES = \
183186
addrman.cpp \
184187
alert.cpp \
@@ -215,6 +218,7 @@ if ENABLE_ZMQ
215218
LIBBITCOIN_ZMQ=libbitcoin_zmq.a
216219

217220
libbitcoin_zmq_a_CPPFLAGS = $(BITCOIN_INCLUDES) $(ZMQ_CFLAGS)
221+
libbitcoin_zmq_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
218222
libbitcoin_zmq_a_SOURCES = \
219223
zmq/zmqabstractnotifier.cpp \
220224
zmq/zmqnotificationinterface.cpp \
@@ -224,7 +228,8 @@ endif
224228

225229
# wallet: shared between bitcoind and bitcoin-qt, but only linked
226230
# when wallet enabled
227-
libbitcoin_wallet_a_CPPFLAGS = $(BITCOIN_INCLUDES)
231+
libbitcoin_wallet_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
232+
libbitcoin_wallet_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
228233
libbitcoin_wallet_a_SOURCES = \
229234
wallet/crypter.cpp \
230235
wallet/db.cpp \
@@ -236,7 +241,8 @@ libbitcoin_wallet_a_SOURCES = \
236241
$(BITCOIN_CORE_H)
237242

238243
# crypto primitives library
239-
crypto_libbitcoin_crypto_a_CPPFLAGS = $(BITCOIN_CONFIG_INCLUDES)
244+
crypto_libbitcoin_crypto_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_CONFIG_INCLUDES)
245+
crypto_libbitcoin_crypto_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
240246
crypto_libbitcoin_crypto_a_SOURCES = \
241247
crypto/common.h \
242248
crypto/hmac_sha256.cpp \
@@ -253,7 +259,8 @@ crypto_libbitcoin_crypto_a_SOURCES = \
253259
crypto/sha512.h
254260

255261
# common: shared between bitcoind, and bitcoin-qt and non-server tools
256-
libbitcoin_common_a_CPPFLAGS = $(BITCOIN_INCLUDES)
262+
libbitcoin_common_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
263+
libbitcoin_common_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
257264
libbitcoin_common_a_SOURCES = \
258265
amount.cpp \
259266
arith_uint256.cpp \
@@ -284,7 +291,8 @@ libbitcoin_common_a_SOURCES = \
284291
# util: shared between all executables.
285292
# This library *must* be included to make sure that the glibc
286293
# backward-compatibility objects and their sanity checks are linked.
287-
libbitcoin_util_a_CPPFLAGS = $(BITCOIN_INCLUDES)
294+
libbitcoin_util_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
295+
libbitcoin_util_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
288296
libbitcoin_util_a_SOURCES = \
289297
support/pagelocker.cpp \
290298
chainparamsbase.cpp \
@@ -308,7 +316,8 @@ libbitcoin_util_a_SOURCES += compat/glibc_compat.cpp
308316
endif
309317

310318
# cli: shared between bitcoin-cli and bitcoin-qt
311-
libbitcoin_cli_a_CPPFLAGS = $(BITCOIN_INCLUDES)
319+
libbitcoin_cli_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
320+
libbitcoin_cli_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
312321
libbitcoin_cli_a_SOURCES = \
313322
rpcclient.cpp \
314323
$(BITCOIN_CORE_H)
@@ -318,7 +327,8 @@ nodist_libbitcoin_util_a_SOURCES = $(srcdir)/obj/build.h
318327

319328
# bitcoind binary #
320329
bitcoind_SOURCES = bitcoind.cpp
321-
bitcoind_CPPFLAGS = $(BITCOIN_INCLUDES)
330+
bitcoind_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
331+
bitcoind_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
322332
bitcoind_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS)
323333

324334
if TARGET_WINDOWS
@@ -347,7 +357,8 @@ bitcoind_LDADD += $(BOOST_LIBS) $(BDB_LIBS) $(SSL_LIBS) $(CRYPTO_LIBS) $(MINIUPN
347357

348358
# bitcoin-cli binary #
349359
bitcoin_cli_SOURCES = bitcoin-cli.cpp
350-
bitcoin_cli_CPPFLAGS = $(BITCOIN_INCLUDES) $(EVENT_CFLAGS)
360+
bitcoin_cli_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) $(EVENT_CFLAGS)
361+
bitcoin_cli_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
351362
bitcoin_cli_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS)
352363

353364
if TARGET_WINDOWS
@@ -364,7 +375,8 @@ bitcoin_cli_LDADD += $(BOOST_LIBS) $(SSL_LIBS) $(CRYPTO_LIBS) $(EVENT_LIBS)
364375

365376
# bitcoin-tx binary #
366377
bitcoin_tx_SOURCES = bitcoin-tx.cpp
367-
bitcoin_tx_CPPFLAGS = $(BITCOIN_INCLUDES)
378+
bitcoin_tx_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
379+
bitcoin_tx_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
368380
bitcoin_tx_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS)
369381

370382
if TARGET_WINDOWS
@@ -405,9 +417,10 @@ if GLIBC_BACK_COMPAT
405417
libbitcoinconsensus_la_SOURCES += compat/glibc_compat.cpp
406418
endif
407419

408-
libbitcoinconsensus_la_LDFLAGS = -no-undefined $(RELDFLAGS)
420+
libbitcoinconsensus_la_LDFLAGS = $(AM_LDFLAGS) -no-undefined $(RELDFLAGS)
409421
libbitcoinconsensus_la_LIBADD = $(CRYPTO_LIBS)
410-
libbitcoinconsensus_la_CPPFLAGS = $(CRYPTO_CFLAGS) -I$(builddir)/obj -DBUILD_BITCOIN_INTERNAL
422+
libbitcoinconsensus_la_CPPFLAGS = $(AM_CPPFLAGS) $(CRYPTO_CFLAGS) -I$(builddir)/obj -DBUILD_BITCOIN_INTERNAL
423+
libbitcoinconsensus_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
411424

412425
endif
413426
#
@@ -443,7 +456,7 @@ clean-local:
443456

444457
.mm.o:
445458
$(AM_V_CXX) $(OBJCXX) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) \
446-
$(CPPFLAGS) $(AM_CXXFLAGS) $(QT_INCLUDES) $(CXXFLAGS) -c -o $@ $<
459+
$(CPPFLAGS) $(AM_CXXFLAGS) $(QT_INCLUDES) $(AM_CXXFLAGS) $(PIE_FLAGS) $(CXXFLAGS) -c -o $@ $<
447460

448461
%.pb.cc %.pb.h: %.proto
449462
@test -f $(PROTOC)

src/Makefile.bench.include

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ bench_bench_bitcoin_SOURCES = \
99
bench/bench.h \
1010
bench/Examples.cpp
1111

12-
bench_bench_bitcoin_CPPFLAGS = $(BITCOIN_INCLUDES) $(EVENT_CLFAGS) $(EVENT_PTHREADS_CFLAGS) -I$(builddir)/bench/
12+
bench_bench_bitcoin_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) $(EVENT_CLFAGS) $(EVENT_PTHREADS_CFLAGS) -I$(builddir)/bench/
13+
bench_bench_bitcoin_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
1314
bench_bench_bitcoin_LDADD = \
1415
$(LIBBITCOIN_SERVER) \
1516
$(LIBBITCOIN_COMMON) \
@@ -31,7 +32,6 @@ endif
3132
bench_bench_bitcoin_LDADD += $(BOOST_LIBS) $(BDB_LIBS) $(SSL_LIBS) $(CRYPTO_LIBS) $(MINIUPNPC_LIBS) $(EVENT_PTHREADS_LIBS) $(EVENT_LIBS)
3233
bench_bench_bitcoin_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS)
3334

34-
3535
CLEAN_BITCOIN_BENCH = bench/*.gcda bench/*.gcno
3636

3737
CLEANFILES += $(CLEAN_BITCOIN_BENCH)

src/Makefile.qt.include

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,9 @@ BITCOIN_RC = qt/res/bitcoin-qt-res.rc
327327
BITCOIN_QT_INCLUDES = -I$(builddir)/qt -I$(srcdir)/qt -I$(srcdir)/qt/forms \
328328
-I$(builddir)/qt/forms -DQT_NO_KEYWORDS
329329

330-
qt_libbitcoinqt_a_CPPFLAGS = $(BITCOIN_INCLUDES) $(BITCOIN_QT_INCLUDES) \
330+
qt_libbitcoinqt_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) $(BITCOIN_QT_INCLUDES) \
331331
$(QT_INCLUDES) $(QT_DBUS_INCLUDES) $(PROTOBUF_CFLAGS) $(QR_CFLAGS)
332+
qt_libbitcoinqt_a_CXXFLAGS = $(AM_CXXFLAGS) $(QT_PIE_FLAGS)
332333

333334
qt_libbitcoinqt_a_SOURCES = $(BITCOIN_QT_CPP) $(BITCOIN_QT_H) $(QT_FORMS_UI) \
334335
$(QT_QRC) $(QT_QRC_LOCALE) $(QT_TS) $(PROTOBUF_PROTO) $(RES_ICONS) $(RES_IMAGES) $(RES_MOVIES)
@@ -350,8 +351,9 @@ $(QT_MOC): $(PROTOBUF_H)
350351
$(QT_MOC_CPP): $(PROTOBUF_H)
351352

352353
# bitcoin-qt binary #
353-
qt_bitcoin_qt_CPPFLAGS = $(BITCOIN_INCLUDES) $(BITCOIN_QT_INCLUDES) \
354+
qt_bitcoin_qt_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) $(BITCOIN_QT_INCLUDES) \
354355
$(QT_INCLUDES) $(PROTOBUF_CFLAGS) $(QR_CFLAGS)
356+
qt_bitcoin_qt_CXXFLAGS = $(AM_CXXFLAGS) $(QT_PIE_FLAGS)
355357

356358
qt_bitcoin_qt_SOURCES = qt/bitcoin.cpp
357359
if TARGET_DARWIN

src/Makefile.qttest.include

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ TEST_QT_H = \
1212
qt/test/paymentrequestdata.h \
1313
qt/test/paymentservertests.h
1414

15-
qt_test_test_bitcoin_qt_CPPFLAGS = $(BITCOIN_INCLUDES) $(BITCOIN_QT_INCLUDES) \
15+
qt_test_test_bitcoin_qt_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) $(BITCOIN_QT_INCLUDES) \
1616
$(QT_INCLUDES) $(QT_TEST_INCLUDES) $(PROTOBUF_CFLAGS)
1717

1818
qt_test_test_bitcoin_qt_SOURCES = \
@@ -38,6 +38,7 @@ qt_test_test_bitcoin_qt_LDADD += $(LIBBITCOIN_CLI) $(LIBBITCOIN_COMMON) $(LIBBIT
3838
$(QR_LIBS) $(PROTOBUF_LIBS) $(BDB_LIBS) $(SSL_LIBS) $(CRYPTO_LIBS) $(MINIUPNPC_LIBS) $(LIBSECP256K1) \
3939
$(EVENT_PTHREADS_LIBS) $(EVENT_LIBS)
4040
qt_test_test_bitcoin_qt_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(QT_LDFLAGS) $(LIBTOOL_APP_LDFLAGS)
41+
qt_test_test_bitcoin_qt_CXXFLAGS = $(AM_CXXFLAGS) $(QT_PIE_FLAGS)
4142

4243
CLEAN_BITCOIN_QT_TEST = $(TEST_QT_MOC_CPP) qt/test/*.gcda qt/test/*.gcno
4344

src/Makefile.test.include

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,10 @@ BITCOIN_TESTS += \
9393
endif
9494

9595
test_test_bitcoin_SOURCES = $(BITCOIN_TESTS) $(JSON_TEST_FILES) $(RAW_TEST_FILES)
96-
test_test_bitcoin_CPPFLAGS = $(BITCOIN_INCLUDES) -I$(builddir)/test/ $(TESTDEFS)
96+
test_test_bitcoin_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) -I$(builddir)/test/ $(TESTDEFS)
9797
test_test_bitcoin_LDADD = $(LIBBITCOIN_SERVER) $(LIBBITCOIN_CLI) $(LIBBITCOIN_COMMON) $(LIBBITCOIN_UTIL) $(LIBBITCOIN_CRYPTO) $(LIBUNIVALUE) $(LIBLEVELDB) $(LIBMEMENV) \
9898
$(BOOST_LIBS) $(BOOST_UNIT_TEST_FRAMEWORK_LIB) $(LIBSECP256K1)
99+
test_test_bitcoin_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
99100
if ENABLE_WALLET
100101
test_test_bitcoin_LDADD += $(LIBBITCOIN_WALLET)
101102
endif

0 commit comments

Comments
 (0)