Skip to content

Commit 3ef2d40

Browse files
author
MarcoFalke
committed
Merge bitcoin/bitcoin#22376: ci: Do not clone bitcoin-core/qa-assets git repository if not necessary
30450a1 Do not clone qa-assets git repository if not necessary (Kiminuo) Pull request description: This PR attempts to remove an unnecessary step when CI runs. The main motivation for the change is that I locally use `MAKEJOBS="-j15" FILE_ENV="./ci/test/00_setup_env_android.sh" ./ci/test_run_all.sh` to find out if a patch of mine works or not. Cloning `bitcoin-core/qa-assets` is slow on my machine (which is by no means slow). ACKs for top commit: MarcoFalke: cr ACK 30450a1 Tree-SHA512: 5763b53da9554b06039c39f8fc729de1b106cce2a242de8f97528d001bfa01d4f48d2a128f458a3cdee3da36312354c6714839b947f313c089c2c5cb30233a39
2 parents 333ec8b + 30450a1 commit 3ef2d40

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

ci/test/04_install.sh

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,14 @@ fi
8484
DOCKER_EXEC echo "Free disk space:"
8585
DOCKER_EXEC df -h
8686

87-
if [ ! -d ${DIR_QA_ASSETS} ]; then
88-
DOCKER_EXEC git clone --depth=1 https://github.com/bitcoin-core/qa-assets ${DIR_QA_ASSETS}
87+
if [ "$RUN_FUZZ_TESTS" = "true" ] || [ "$RUN_UNIT_TESTS" = "true" ] || [ "$RUN_UNIT_TESTS_SEQUENTIAL" = "true" ]; then
88+
if [ ! -d ${DIR_QA_ASSETS} ]; then
89+
DOCKER_EXEC git clone --depth=1 https://github.com/bitcoin-core/qa-assets ${DIR_QA_ASSETS}
90+
fi
91+
92+
export DIR_FUZZ_IN=${DIR_QA_ASSETS}/fuzz_seed_corpus/
93+
export DIR_UNIT_TEST_DATA=${DIR_QA_ASSETS}/unit_test_data/
8994
fi
90-
export DIR_FUZZ_IN=${DIR_QA_ASSETS}/fuzz_seed_corpus/
91-
export DIR_UNIT_TEST_DATA=${DIR_QA_ASSETS}/unit_test_data/
9295

9396
DOCKER_EXEC mkdir -p "${BASE_SCRATCH_DIR}/sanitizer-output/"
9497

0 commit comments

Comments
 (0)