Skip to content

Commit 3f8d955

Browse files
committed
Merge #17345: test: Do not instantiate CAddrDB for static call CAddrDB::Read()
59853c3 test: Do not instantiate CAddrDB for static call (Hennadii Stepanov) Pull request description: Ref: https://github.com/bitcoin/bitcoin/blob/6a7c40bee403cadedeecd4b1c6528575522094eb/src/addrdb.h#L84-L94 ACKs for top commit: MarcoFalke: unsigned ACK 59853c3 naumenkogs: ACK 59853c3 Tree-SHA512: 06b2e8e4f2b4a4f20454a4828a786878fc2bd441b0ee53f1128a7a0b6ad54dd3ca7598cee000ec60e5e4ef02570a09c01974d2d8260bd11fa9baf16b3ff9ba08
2 parents 6a7c40b + 59853c3 commit 3f8d955

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/test/net_tests.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,8 @@ BOOST_AUTO_TEST_CASE(caddrdb_read)
128128
CDataStream ssPeers2 = AddrmanToStream(addrmanUncorrupted);
129129

130130
CAddrMan addrman2;
131-
CAddrDB adb;
132131
BOOST_CHECK(addrman2.size() == 0);
133-
BOOST_CHECK(adb.Read(addrman2, ssPeers2));
132+
BOOST_CHECK(CAddrDB::Read(addrman2, ssPeers2));
134133
BOOST_CHECK(addrman2.size() == 3);
135134
}
136135

@@ -160,9 +159,8 @@ BOOST_AUTO_TEST_CASE(caddrdb_read_corrupted)
160159
CDataStream ssPeers2 = AddrmanToStream(addrmanCorrupted);
161160

162161
CAddrMan addrman2;
163-
CAddrDB adb;
164162
BOOST_CHECK(addrman2.size() == 0);
165-
BOOST_CHECK(!adb.Read(addrman2, ssPeers2));
163+
BOOST_CHECK(!CAddrDB::Read(addrman2, ssPeers2));
166164
BOOST_CHECK(addrman2.size() == 0);
167165
}
168166

0 commit comments

Comments
 (0)