Skip to content

Commit 3fcc468

Browse files
committed
Prefer explicit CScriptID construction
1 parent 0a5ea32 commit 3fcc468

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/script/sign.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ static bool SignStep(const SigningProvider& provider, const BaseSignatureCreator
131131
}
132132
case TX_SCRIPTHASH:
133133
h160 = uint160(vSolutions[0]);
134-
if (GetCScript(provider, sigdata, h160, scriptRet)) {
134+
if (GetCScript(provider, sigdata, CScriptID{h160}, scriptRet)) {
135135
ret.push_back(std::vector<unsigned char>(scriptRet.begin(), scriptRet.end()));
136136
return true;
137137
}
@@ -165,7 +165,7 @@ static bool SignStep(const SigningProvider& provider, const BaseSignatureCreator
165165

166166
case TX_WITNESS_V0_SCRIPTHASH:
167167
CRIPEMD160().Write(&vSolutions[0][0], vSolutions[0].size()).Finalize(h160.begin());
168-
if (GetCScript(provider, sigdata, h160, scriptRet)) {
168+
if (GetCScript(provider, sigdata, CScriptID{h160}, scriptRet)) {
169169
ret.push_back(std::vector<unsigned char>(scriptRet.begin(), scriptRet.end()));
170170
return true;
171171
}
@@ -458,7 +458,7 @@ bool IsSegWitOutput(const SigningProvider& provider, const CScript& script)
458458
if (whichtype == TX_SCRIPTHASH) {
459459
auto h160 = uint160(solutions[0]);
460460
CScript subscript;
461-
if (provider.GetCScript(h160, subscript)) {
461+
if (provider.GetCScript(CScriptID{h160}, subscript)) {
462462
whichtype = Solver(subscript, solutions);
463463
if (whichtype == TX_WITNESS_V0_SCRIPTHASH || whichtype == TX_WITNESS_V0_KEYHASH || whichtype == TX_WITNESS_UNKNOWN) return true;
464464
}

src/script/standard.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class CScriptID : public uint160
2525
public:
2626
CScriptID() : uint160() {}
2727
explicit CScriptID(const CScript& in);
28-
CScriptID(const uint160& in) : uint160(in) {}
28+
explicit CScriptID(const uint160& in) : uint160(in) {}
2929
};
3030

3131
/**

0 commit comments

Comments
 (0)