Merge #21082: refactor: Treat ArgsManager::Flags as uint32_t explicitly

MarcoFalke · MarcoFalke · commit 4013e44c7444 · 2021-02-05T09:54:43.000+01:00
faf3b4b refactor: Treat ArgsManager::Flags as uint32_t explicitly (MarcoFalke) Pull request description: The underlying type might be implementation defined, which is probably why the sanitizer kills the fuzz tests. Fix that by pinning the underlying type. This refactor does not change behaviour and only affects the sanitizer in tests. ACKs for top commit: practicalswift: cr ACK faf3b4b Tree-SHA512: d446824836e1037b4200ba3630c8628090678cfad45559866275d8e06349f7c8cdb7e816619f5afb35f9f65299cc00e046d2f81b73cd8eb843e2e15676b647d5
diff --git a/src/util/system.h b/src/util/system.h
@@ -166,7 +166,7 @@ struct SectionInfo
 class ArgsManager
 {
 public:
-    enum Flags {
+    enum Flags : uint32_t {
         // Boolean options can accept negation syntax -noOPTION or -noOPTION=1
         ALLOW_BOOL = 0x01,
         ALLOW_INT = 0x02,

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ struct SectionInfo`
`166`	`166`	`class ArgsManager`
`167`	`167`	`{`
`168`	`168`	`public:`
`169`		`- enum Flags {`
	`169`	`+ enum Flags : uint32_t {`
`170`	`170`	`// Boolean options can accept negation syntax -noOPTION or -noOPTION=1`
`171`	`171`	`ALLOW_BOOL = 0x01,`
`172`	`172`	`ALLOW_INT = 0x02,`