Skip to content

Commit 4053de0

Browse files
committed
Merge #19859: qa: Fixes failing functional test by changing version
6de9429 qa: Changes v0.17.1 to v0.17.2 (nthumann) Pull request description: As of bitcoin/bitcoin@0374e82 v0.17.2 is downloaded instead of v0.17.1 for functional testing. This causes `test/functional/feature_backwards_compatibility.py` to fail, because it [requires](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_backwards_compatibility.py#L57) v0.17.1. Steps to reproduce: Run `test/get_previous_releases.py -b v0.19.1 v0.18.1 v0.17.1 v0.16.3 v0.15.2`. It cannot be downloaded at all because the sha256sum is missing [here](https://github.com/bitcoin/bitcoin/blob/c1e0c2ad3b6cd9e7ef55287fb572cfcf10a0e660/test/get_previous_releases.py#L23). Or adjust the command and run `test/get_previous_releases.py -b v0.19.1 v0.18.1 v0.17.2 v0.16.3 v0.15.2`, then run `test/functional/test_runner.py feature_backwards_compatibility`. It´ll fail because the test is missing v0.17.1. This PR changes v0.17.1 to v0.17.2 in this test and in a few comments. ACKs for top commit: laanwj: ACK 6de9429 fanquake: ACK 6de9429 - looks correct. Surprised this wasn't caught/part of #19813. In future you could add any explanations & extra info as part of your commit message as well (even though PR descriptions are included as part of the merge). Tree-SHA512: bbe50c4fd5c1aedd6dc1cdc3d93ef9005db1c67adca3f263b6b0d869c40b495a3221e706c9389fedea4748e31911dbd591062f60ce9836e58099fbdd9515b4d9
2 parents 620ac8c + 6de9429 commit 4053de0

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

test/functional/feature_backwards_compatibility.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
77
Test various backwards compatibility scenarios. Download the previous node binaries:
88
9-
test/get_previous_releases.py -b v0.19.1 v0.18.1 v0.17.1 v0.16.3 v0.15.2
9+
test/get_previous_releases.py -b v0.19.1 v0.18.1 v0.17.2 v0.16.3 v0.15.2
1010
1111
v0.15.2 is not required by this test, but it is used in wallet_upgradewallet.py.
1212
Due to a hardfork in regtest, it can't be used to sync nodes.
@@ -40,7 +40,7 @@ def set_test_params(self):
4040
["-nowallet", "-walletrbf=1", "-addresstype=bech32"], # Pre-release: use to receive coins, swap wallets, etc
4141
["-nowallet", "-walletrbf=1", "-addresstype=bech32"], # v0.19.1
4242
["-nowallet", "-walletrbf=1", "-addresstype=bech32"], # v0.18.1
43-
["-nowallet", "-walletrbf=1", "-addresstype=bech32"], # v0.17.1
43+
["-nowallet", "-walletrbf=1", "-addresstype=bech32"], # v0.17.2
4444
["-nowallet", "-walletrbf=1", "-addresstype=bech32"], # v0.16.3
4545
]
4646

@@ -54,7 +54,7 @@ def setup_nodes(self):
5454
None,
5555
190100,
5656
180100,
57-
170100,
57+
170200,
5858
160300,
5959
])
6060

test/functional/mempool_compatibility.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
In case we need to break mempool compatibility we can continue to use the test by just bumping the version number.
99
1010
Download node binaries:
11-
test/get_previous_releases.py -b v0.19.1 v0.18.1 v0.17.1 v0.16.3 v0.15.2
11+
test/get_previous_releases.py -b v0.19.1 v0.18.1 v0.17.2 v0.16.3 v0.15.2
1212
1313
Only v0.15.2 is required by this test. The rest is used in other backwards compatibility tests.
1414
"""

test/functional/wallet_upgradewallet.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
77
Test upgradewallet RPC. Download node binaries:
88
9-
test/get_previous_releases.py -b v0.19.1 v0.18.1 v0.17.1 v0.16.3 v0.15.2
9+
test/get_previous_releases.py -b v0.19.1 v0.18.1 v0.17.2 v0.16.3 v0.15.2
1010
1111
Only v0.15.2 and v0.16.3 are required by this test. The others are used in feature_backwards_compatibility.py
1212
"""

0 commit comments

Comments
 (0)