Merge #18026: psbt_wallet_tests: use unique_ptr for GetSigningProvider

fanquake · fanquake · commit 44c2400bccbc · 2020-01-30T15:23:53.000+08:00
1115ba6 psbt_wallet_tests: use unique_ptr for GetSigningProvider (Anthony Towns) Pull request description: #17261 changed GetSigningProvider to return a unique_ptr, but #17156 made psbt_wallet_tests use it as well, and wasn't correspondingly updated. ACKs for top commit: fanquake: ACK 1115ba6 meshcollider: Thanks! utACK 1115ba6 Tree-SHA512: f0191c9b00780e6d1445fa4ec531456758b468b5bca8660474d22b1edb5f48a636a940656c9bdbe466b8bffad7af1e57e0756239906e901d60c69c3124d3bff4
diff --git a/src/wallet/test/psbt_wallet_tests.cpp b/src/wallet/test/psbt_wallet_tests.cpp
@@ -75,7 +75,7 @@ BOOST_AUTO_TEST_CASE(psbt_updater_test)
     // Try to sign the mutated input
     SignatureData sigdata;
     psbtx.inputs[0].FillSignatureData(sigdata);
-    const SigningProvider* provider = m_wallet.GetSigningProvider(ws1, sigdata);
+    const std::unique_ptr<SigningProvider> provider = m_wallet.GetSigningProvider(ws1, sigdata);
     BOOST_CHECK(!SignPSBTInput(*provider, psbtx, 0, SIGHASH_ALL));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ BOOST_AUTO_TEST_CASE(psbt_updater_test)`
`75`	`75`	`// Try to sign the mutated input`
`76`	`76`	`SignatureData sigdata;`
`77`	`77`	`psbtx.inputs[0].FillSignatureData(sigdata);`
`78`		`- const SigningProvider* provider = m_wallet.GetSigningProvider(ws1, sigdata);`
	`78`	`+ const std::unique_ptr<SigningProvider> provider = m_wallet.GetSigningProvider(ws1, sigdata);`
`79`	`79`	`BOOST_CHECK(!SignPSBTInput(*provider, psbtx, 0, SIGHASH_ALL));`
`80`	`80`	`}`
`81`	`81`