Exit early for an empty vChecks in CCheckQueue::Add

hebasto · hebasto · commit 459e208276a4 · 2021-11-03T11:26:57.000+02:00
diff --git a/src/checkqueue.h b/src/checkqueue.h
@@ -167,6 +167,10 @@ class CCheckQueue
     //! Add a batch of checks to the queue
     void Add(std::vector<T>& vChecks)
     {
+        if (vChecks.empty()) {
+            return;
+        }
+
         {
             LOCK(m_mutex);
             for (T& check : vChecks) {
@@ -176,10 +180,11 @@ class CCheckQueue
             nTodo += vChecks.size();
         }
 
-        if (vChecks.size() == 1)
+        if (vChecks.size() == 1) {
             m_worker_cv.notify_one();
-        else if (vChecks.size() > 1)
+        } else {
             m_worker_cv.notify_all();
+        }
     }
 
     //! Stop all of the worker threads.

Original file line number	Diff line number	Diff line change
`@@ -167,6 +167,10 @@ class CCheckQueue`
`167`	`167`	`//! Add a batch of checks to the queue`
`168`	`168`	`void Add(std::vector<T>& vChecks)`
`169`	`169`	`{`
	`170`	`+ if (vChecks.empty()) {`
	`171`	`+ return;`
	`172`	`+ }`
	`173`	`+`
`170`	`174`	`{`
`171`	`175`	`LOCK(m_mutex);`
`172`	`176`	`for (T& check : vChecks) {`
`@@ -176,10 +180,11 @@ class CCheckQueue`
`176`	`180`	`nTodo += vChecks.size();`
`177`	`181`	`}`
`178`	`182`
`179`		`- if (vChecks.size() == 1)`
	`183`	`+ if (vChecks.size() == 1) {`
`180`	`184`	`m_worker_cv.notify_one();`
`181`		`- else if (vChecks.size() > 1)`
	`185`	`+ } else {`
`182`	`186`	`m_worker_cv.notify_all();`
	`187`	`+ }`
`183`	`188`	`}`
`184`	`189`
`185`	`190`	`//! Stop all of the worker threads.`