Skip to content

Commit 464b34d

Browse files
committed
macdeploy: remove codesigning argument
1 parent 4d70d3d commit 464b34d

File tree

1 file changed

+1
-15
lines changed

1 file changed

+1
-15
lines changed

contrib/macdeploy/macdeployqtplus

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -514,17 +514,12 @@ ap = ArgumentParser(description="""Improved version of macdeployqt.
514514
Outputs a ready-to-deploy app in a folder "dist" and optionally wraps it in a .dmg file.
515515
Note, that the "dist" folder will be deleted before deploying on each run.
516516
517-
Optionally, Qt translation files (.qm) and additional resources can be added to the bundle.
518-
519-
Also optionally signs the .app bundle; set the CODESIGNARGS environment variable to pass arguments
520-
to the codesign tool.
521-
E.g. CODESIGNARGS='--sign "Developer ID Application: ..." --keychain /encrypted/foo.keychain'""")
517+
Optionally, Qt translation files (.qm) and additional resources can be added to the bundle.""")
522518

523519
ap.add_argument("app_bundle", nargs=1, metavar="app-bundle", help="application bundle to be deployed")
524520
ap.add_argument("-verbose", type=int, nargs=1, default=[1], metavar="<0-3>", help="0 = no output, 1 = error/warning (default), 2 = normal, 3 = debug")
525521
ap.add_argument("-no-plugins", dest="plugins", action="store_false", default=True, help="skip plugin deployment")
526522
ap.add_argument("-no-strip", dest="strip", action="store_false", default=True, help="don't run 'strip' on the binaries")
527-
ap.add_argument("-sign", dest="sign", action="store_true", default=False, help="sign .app bundle with codesign tool")
528523
ap.add_argument("-dmg", nargs="?", const="", metavar="basename", help="create a .dmg disk image; if basename is not specified, a camel-cased version of the app name is used")
529524
ap.add_argument("-fancy", nargs=1, metavar="plist", default=[], help="make a fancy looking disk image using the given plist file with instructions; requires -dmg to work")
530525
ap.add_argument("-translations-dir", nargs=1, metavar="path", default=None, help="Path to Qt's translations. Base translations will automatically be added to the bundle's resources.")
@@ -718,15 +713,6 @@ for p in config.add_resources:
718713

719714
# ------------------------------------------------
720715

721-
if config.sign and 'CODESIGNARGS' not in os.environ:
722-
print("You must set the CODESIGNARGS environment variable. Skipping signing.")
723-
elif config.sign:
724-
if verbose >= 1:
725-
print("Code-signing app bundle {}".format(target))
726-
subprocess.check_call("codesign --force {} {}".format(os.environ['CODESIGNARGS'], target), shell=True)
727-
728-
# ------------------------------------------------
729-
730716
if config.dmg is not None:
731717

732718
def runHDIUtil(verb: str, image_basename: str, **kwargs) -> int:

0 commit comments

Comments
 (0)