Skip to content

Commit 4987cdd

Browse files
author
MarcoFalke
committed
Merge #14882: [doc] developer-notes.md: point out that UniValue deviates from upstream
a67d713 [doc] developer-notes.md: point out that UniValue deviates from upstream (Sjors Provoost) Pull request description: While debugging an issue I was somewhat surprised to [learn](bitcoin/bitcoin#14164 (comment)) that we've moved `src/univalue` from https://github.com/jgarzik/univalue to https://github.com/bitcoin-core/univalue, that these repos are both maintained and they're different. The first mention of using the bitcoin-core repo is from late 2015 in #7157. I didn't check when the last common ancestor commit is. I couldn't find documentation as to why (these things just happen in open source of course), but at minimum we should make this more clear. There's also the following line in `config.ac` that I'm not sure what to do with: ``` AC_INIT([univalue], [1.0.3], [http://github.com/jgarzik/univalue/]) ``` Tree-SHA512: e58105677b5ebe0005772282da4a805fee7dfccacfb1b2686a874517bf46072d1481181f8a8865d25526f6ed9e5fcd55d8d49906bf27cd0f5aefe4f258aa4d63
2 parents 01bc479 + a67d713 commit 4987cdd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

doc/developer-notes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -741,7 +741,7 @@ Current subtrees include:
741741
- Upstream at https://github.com/bitcoin-core/ctaes ; actively maintained by Core contributors.
742742

743743
- src/univalue
744-
- Upstream at https://github.com/jgarzik/univalue ; report important PRs to Core to avoid delay.
744+
- Upstream at https://github.com/bitcoin-core/univalue ; actively maintained by Core contributors, deviates from upstream https://github.com/jgarzik/univalue
745745

746746
Upgrading LevelDB
747747
---------------------

0 commit comments

Comments
 (0)