Skip to content

Commit 49d237c

Browse files
committed
Merge #18928: build: don't pass -w when building for Windows
89fea68 build: don't pass -w when building for Windows (fanquake) Pull request description: This has been around since the introduction of autotools. However at this point I'm not sure we'd ever want to suppress all warnings when performing a build, and given that CXX FLAGS will have been overriden when cross-compiling for Windows (using depends), this would rarely, if-ever be used anyways. From https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html: > -w > > Inhibit all warning messages. ACKs for top commit: hebasto: ACK 89fea68 Tree-SHA512: 2b5bdef7fff5c87b28199f5822cab3cdf600c90c01a40db5cd85053eef5dcb5816e2e97ff61a30ff94b4f0c6cb7be22beaef34d82235bdf05ff9da865d40b381
2 parents 7a57674 + 89fea68 commit 49d237c

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

configure.ac

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -578,9 +578,6 @@ case $host in
578578
fi
579579

580580
CPPFLAGS="$CPPFLAGS -D_MT -DWIN32 -D_WINDOWS -DBOOST_THREAD_USE_LIB -D_WIN32_WINNT=0x0601"
581-
if test "x$CXXFLAGS_overridden" = "xno"; then
582-
CXXFLAGS="$CXXFLAGS -w"
583-
fi
584581

585582
dnl libtool insists upon adding -nostdlib and a list of objects/libs to link against.
586583
dnl That breaks our ability to build dll's with static libgcc/libstdc++/libssp. Override

0 commit comments

Comments
 (0)