Merge bitcoin-core#277: Do not use QClipboard::Selection on Windows and macOS.

MarcoFalke · MarcoFalke · commit 4a1751a929cc · 2021-04-17T13:28:25.000+02:00
7f3a598 qt: Do not use QClipboard::Selection on Windows and macOS. (Hennadii Stepanov) Pull request description: Windows and macOS do [not support](https://doc.qt.io/qt-5/qclipboard.html#notes-for-windows-and-macos-users) the global mouse selection. Fixes bitcoin-core#258. ACKs for top commit: promag: Code review ACK 7f3a598. jarolrod: ACK 7f3a598 Tree-SHA512: be2beeef7d25af6f4d4a4548325d8d29f08e4342f499666bc4a670ed468a63195d514077c2cd0dba197e12bd43316fd3e2813cdc0954364b6aa4ae6b90c118bf
diff --git a/src/qt/guiutil.cpp b/src/qt/guiutil.cpp
@@ -630,8 +630,11 @@ bool SetStartOnSystemStartup(bool fAutoStart) { return false; }
 
 void setClipboard(const QString& str)
 {
-    QApplication::clipboard()->setText(str, QClipboard::Clipboard);
-    QApplication::clipboard()->setText(str, QClipboard::Selection);
+    QClipboard* clipboard = QApplication::clipboard();
+    clipboard->setText(str, QClipboard::Clipboard);
+    if (clipboard->supportsSelection()) {
+        clipboard->setText(str, QClipboard::Selection);
+    }
 }
 
 fs::path qstringToBoostPath(const QString &path)

Original file line number	Diff line number	Diff line change
`@@ -630,8 +630,11 @@ bool SetStartOnSystemStartup(bool fAutoStart) { return false; }`
`630`	`630`
`631`	`631`	`void setClipboard(const QString& str)`
`632`	`632`	`{`
`633`		`- QApplication::clipboard()->setText(str, QClipboard::Clipboard);`
`634`		`- QApplication::clipboard()->setText(str, QClipboard::Selection);`
	`633`	`+ QClipboard* clipboard = QApplication::clipboard();`
	`634`	`+ clipboard->setText(str, QClipboard::Clipboard);`
	`635`	`+ if (clipboard->supportsSelection()) {`
	`636`	`+ clipboard->setText(str, QClipboard::Selection);`
	`637`	`+ }`
`635`	`638`	`}`
`636`	`639`
`637`	`640`	`fs::path qstringToBoostPath(const QString &path)`