Skip to content

Commit 4b189c1

Browse files
committed
Change bumpfee result value from 'oldfee' to 'origfee'.
The result value indicates the actual fee on the transaction that was replaced. But there is an error message which uses the description 'oldfee' to refer to the original fee rate applied to the new transaction's estimated max size. It was confusing that two different uses of 'oldfee' had two different numeric values.
1 parent 0c0c63f commit 4b189c1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/wallet/rpcwallet.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2674,8 +2674,8 @@ UniValue bumpfee(const JSONRPCRequest& request)
26742674
"\nResult:\n"
26752675
"{\n"
26762676
" \"txid\": \"value\", (string) The id of the new transaction\n"
2677-
" \"oldfee\": n, (numeric) Fee of the replaced transaction\n"
2678-
" \"fee\": n, (numeric) Fee of the new transaction\n"
2677+
" \"origfee\": n, (numeric) Fee of the replaced transaction\n"
2678+
" \"fee\": n, (numeric) Fee of the new transaction\n"
26792679
"}\n"
26802680
"\nExamples:\n"
26812681
"\nBump the fee, get the new transaction\'s txid\n" +
@@ -2899,7 +2899,7 @@ UniValue bumpfee(const JSONRPCRequest& request)
28992899

29002900
UniValue result(UniValue::VOBJ);
29012901
result.push_back(Pair("txid", wtxBumped.GetHash().GetHex()));
2902-
result.push_back(Pair("oldfee", ValueFromAmount(nOldFee)));
2902+
result.push_back(Pair("origfee", ValueFromAmount(nOldFee)));
29032903
result.push_back(Pair("fee", ValueFromAmount(nNewFee)));
29042904

29052905
return result;

0 commit comments

Comments
 (0)