Skip to content

Commit 4e15a28

Browse files
committed
Merge bitcoin/bitcoin#26135: build: remove strings.h from header checks
eb6026b build: remove strings.h from header checks (fanquake) Pull request description: We don't include `strings.h` anywhere. This is also already checked for by autoconf, so us checking for it just means a 3rd existence check during `./configure`. ACKs for top commit: TheCharlatan: Code review ACK eb6026b hebasto: ACK eb6026b, tested on macOS 12.6: Tree-SHA512: 4036c21b2f659140e9f471b4d24336fe925c6c010e2ced36e1f606d9c76dea236d086d15a884eb8f95381b39322abeecab973b10532527005fdadd095411e358
2 parents 25cd47d + eb6026b commit 4e15a28

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

build_msvc/bitcoin_config.h.in

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,6 @@
152152
/* Define to 1 if you have the <stdlib.h> header file. */
153153
#define HAVE_STDLIB_H 1
154154

155-
/* Define to 1 if you have the <strings.h> header file. */
156-
#define HAVE_STRINGS_H 1
157-
158155
/* Define to 1 if you have the <string.h> header file. */
159156
#define HAVE_STRING_H 1
160157

configure.ac

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1010,7 +1010,7 @@ if test "$TARGET_OS" = "darwin"; then
10101010
AX_CHECK_LINK_FLAG([-Wl,-bind_at_load], [HARDENED_LDFLAGS="$HARDENED_LDFLAGS -Wl,-bind_at_load"], [], [$LDFLAG_WERROR])
10111011
fi
10121012

1013-
AC_CHECK_HEADERS([endian.h sys/endian.h byteswap.h stdio.h stdlib.h unistd.h strings.h sys/types.h sys/stat.h sys/select.h sys/prctl.h sys/sysctl.h vm/vm_param.h sys/vmmeter.h sys/resources.h])
1013+
AC_CHECK_HEADERS([endian.h sys/endian.h byteswap.h stdio.h stdlib.h unistd.h sys/types.h sys/stat.h sys/select.h sys/prctl.h sys/sysctl.h vm/vm_param.h sys/vmmeter.h sys/resources.h])
10141014

10151015
AC_CHECK_DECLS([getifaddrs, freeifaddrs],[CHECK_SOCKET],,
10161016
[#include <sys/types.h>

0 commit comments

Comments
 (0)