Skip to content

Commit 504c72a

Browse files
committed
Comment that most dnsseeds only support some service bits combos
1 parent ef3402d commit 504c72a

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/chainparams.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,12 +113,13 @@ class CMainParams : public CChainParams {
113113
assert(consensus.hashGenesisBlock == uint256S("0x000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f"));
114114
assert(genesis.hashMerkleRoot == uint256S("0x4a5e1e4baab89f3a32518a88c31bc87f618f76673e2cc77ab2127b7afdeda33b"));
115115

116-
vSeeds.push_back(CDNSSeedData("bitcoin.sipa.be", "seed.bitcoin.sipa.be", true)); // Pieter Wuille
116+
// Note that of those with the service bits flag, most only support a subset of possible options
117+
vSeeds.push_back(CDNSSeedData("bitcoin.sipa.be", "seed.bitcoin.sipa.be", true)); // Pieter Wuille, only supports x1, x5, x9, and xd
117118
vSeeds.push_back(CDNSSeedData("bluematt.me", "dnsseed.bluematt.me")); // Matt Corallo
118119
vSeeds.push_back(CDNSSeedData("dashjr.org", "dnsseed.bitcoin.dashjr.org")); // Luke Dashjr
119120
vSeeds.push_back(CDNSSeedData("bitcoinstats.com", "seed.bitcoinstats.com")); // Christian Decker
120121
vSeeds.push_back(CDNSSeedData("xf2.org", "bitseed.xf2.org")); // Jeff Garzik
121-
vSeeds.push_back(CDNSSeedData("bitcoin.jonasschnelli.ch", "seed.bitcoin.jonasschnelli.ch", true)); // Jonas Schnelli
122+
vSeeds.push_back(CDNSSeedData("bitcoin.jonasschnelli.ch", "seed.bitcoin.jonasschnelli.ch", true)); // Jonas Schnelli, only supports x1, x5, x9, and xd
122123

123124
base58Prefixes[PUBKEY_ADDRESS] = std::vector<unsigned char>(1,0);
124125
base58Prefixes[SCRIPT_ADDRESS] = std::vector<unsigned char>(1,5);

src/net.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1454,6 +1454,7 @@ static std::string GetDNSHost(const CDNSSeedData& data, ServiceFlags* requiredSe
14541454
return data.host;
14551455
}
14561456

1457+
// See chainparams.cpp, most dnsseeds only support one or two possible servicebits hostnames
14571458
return strprintf("x%x.%s", *requiredServiceBits, data.host);
14581459
}
14591460

0 commit comments

Comments
 (0)