script: Make ComputeEntrySchnorr and ComputeEntryECDSA const to clarify contract

practicalswift · practicalswift · commit 51365674e828 · 2020-10-16T06:26:46.000Z
diff --git a/src/script/sigcache.cpp b/src/script/sigcache.cpp
@@ -46,14 +46,14 @@ class CSignatureCache
     }
 
     void
-    ComputeEntryECDSA(uint256& entry, const uint256 &hash, const std::vector<unsigned char>& vchSig, const CPubKey& pubkey)
+    ComputeEntryECDSA(uint256& entry, const uint256 &hash, const std::vector<unsigned char>& vchSig, const CPubKey& pubkey) const
     {
         CSHA256 hasher = m_salted_hasher_ecdsa;
         hasher.Write(hash.begin(), 32).Write(&pubkey[0], pubkey.size()).Write(&vchSig[0], vchSig.size()).Finalize(entry.begin());
     }
 
     void
-    ComputeEntrySchnorr(uint256& entry, const uint256 &hash, Span<const unsigned char> sig, const XOnlyPubKey& pubkey)
+    ComputeEntrySchnorr(uint256& entry, const uint256 &hash, Span<const unsigned char> sig, const XOnlyPubKey& pubkey) const
     {
         CSHA256 hasher = m_salted_hasher_schnorr;
         hasher.Write(hash.begin(), 32).Write(&pubkey[0], pubkey.size()).Write(sig.data(), sig.size()).Finalize(entry.begin());

Original file line number	Diff line number	Diff line change
`@@ -46,14 +46,14 @@ class CSignatureCache`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`void`
`49`		`- ComputeEntryECDSA(uint256& entry, const uint256 &hash, const std::vector<unsigned char>& vchSig, const CPubKey& pubkey)`
	`49`	`+ ComputeEntryECDSA(uint256& entry, const uint256 &hash, const std::vector<unsigned char>& vchSig, const CPubKey& pubkey) const`
`50`	`50`	`{`
`51`	`51`	`CSHA256 hasher = m_salted_hasher_ecdsa;`
`52`	`52`	`hasher.Write(hash.begin(), 32).Write(&pubkey[0], pubkey.size()).Write(&vchSig[0], vchSig.size()).Finalize(entry.begin());`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`void`
`56`		`- ComputeEntrySchnorr(uint256& entry, const uint256 &hash, Span<const unsigned char> sig, const XOnlyPubKey& pubkey)`
	`56`	`+ ComputeEntrySchnorr(uint256& entry, const uint256 &hash, Span<const unsigned char> sig, const XOnlyPubKey& pubkey) const`
`57`	`57`	`{`
`58`	`58`	`CSHA256 hasher = m_salted_hasher_schnorr;`
`59`	`59`	`hasher.Write(hash.begin(), 32).Write(&pubkey[0], pubkey.size()).Write(sig.data(), sig.size()).Finalize(entry.begin());`