Skip to content

Commit 53494bc

Browse files
committed
validation: Have ChainstateManager own m_chainparams
We want m_chainparams to be alive for the duration of ChainstateManager's lifetime since ChainstateManager's behaviour depends on m_chainparams. We could allow for a std::shared_ptr to be passed in as m_chainparams, but that complicates things further. Given that CChainParams is not an entity class or struct, we can just copy it and have ChainstateManager own it.
1 parent 04c31c1 commit 53494bc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/validation.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -836,7 +836,7 @@ class ChainstateManager
836836

837837
CBlockIndex* m_best_invalid GUARDED_BY(::cs_main){nullptr};
838838

839-
const CChainParams& m_chainparams;
839+
const CChainParams m_chainparams;
840840

841841
const std::function<int64_t()> m_adjusted_time_callback;
842842

0 commit comments

Comments
 (0)