Skip to content

Commit 54d5ba3

Browse files
author
MarcoFalke
committed
Merge #18540: test: wallet_bumpfee assertion fixup
b224b4e test: wallet_bumpfee assertion fixup (Jon Atack) Pull request description: Follow-up to #18516 to fix up an assertion as per suggested change in bitcoin/bitcoin#18516 (comment). ACKs for top commit: jnewbery: ACK b224b4e Tree-SHA512: 4973bba73a67c1ffaf460921b3d454e9d66a40a67f73b7df742e24a0e389adba3946a3958a729391ee6bfa4ef844be759ebf71d14d788434c248e48a2bbe5bde
2 parents c0b389b + b224b4e commit 54d5ba3

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/functional/wallet_bumpfee.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,7 @@ def test_dust_to_fee(self, rbf_node, dest_address):
258258
# in the witness is divided by 4 for the vsize, so this variance can take the weight across a 4-byte
259259
# boundary. Thus expected transaction size (p2wpkh, 1 input, 2 outputs) is 140-141 vbytes, usually 141.
260260
if not 140 <= fulltx["vsize"] <= 141:
261-
print("Error: Invalid tx vsize of {} (140-141 expected), full tx: {}".format(fulltx["vsize"], fulltx))
262-
raise AssertionError
261+
raise AssertionError("Invalid tx vsize of {} (140-141 expected), full tx: {}".format(fulltx["vsize"], fulltx))
263262
# Bump with fee_rate of 0.00350250 BTC per 1000 vbytes to create dust.
264263
# Expected fee is 141 vbytes * fee_rate 0.00350250 BTC / 1000 vbytes = 0.00049385 BTC.
265264
# or occasionally 140 vbytes * fee_rate 0.00350250 BTC / 1000 vbytes = 0.00049035 BTC.

0 commit comments

Comments
 (0)