Do not shadow upper local variable state.

paveljanik · paveljanik · commit 5618b7d1ad3f · 2017-07-08T09:30:35.000+02:00
diff --git a/src/test/txvalidationcache_tests.cpp b/src/test/txvalidationcache_tests.cpp
@@ -196,8 +196,8 @@ BOOST_FIXTURE_TEST_CASE(checkinputs_test, TestChain100Setup)
     // Test that invalidity under a set of flags doesn't preclude validity
     // under other (eg consensus) flags.
     // spend_tx is invalid according to DERSIG
-    CValidationState state;
     {
+        CValidationState state;
         PrecomputedTransactionData ptd_spend_tx(spend_tx);
 
         BOOST_CHECK(!CheckInputs(spend_tx, state, pcoinsTip, true, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_DERSIG, true, true, ptd_spend_tx, nullptr));

Original file line number	Diff line number	Diff line change
`@@ -196,8 +196,8 @@ BOOST_FIXTURE_TEST_CASE(checkinputs_test, TestChain100Setup)`
`196`	`196`	`// Test that invalidity under a set of flags doesn't preclude validity`
`197`	`197`	`// under other (eg consensus) flags.`
`198`	`198`	`// spend_tx is invalid according to DERSIG`
`199`		`- CValidationState state;`
`200`	`199`	`{`
	`200`	`+ CValidationState state;`
`201`	`201`	`PrecomputedTransactionData ptd_spend_tx(spend_tx);`
`202`	`202`
`203`	`203`	`BOOST_CHECK(!CheckInputs(spend_tx, state, pcoinsTip, true, SCRIPT_VERIFY_P2SH \| SCRIPT_VERIFY_DERSIG, true, true, ptd_spend_tx, nullptr));`