Skip to content

Commit 5ba9f1f

Browse files
committed
test: refactor: rename NULLDUMMY-invalidation helper
The name is changed to match the coding guidelines (snake case) and to be more descriptive.
1 parent e1d4a12 commit 5ba9f1f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/functional/feature_nulldummy.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
NULLDUMMY_ERROR = "non-mandatory-script-verify-flag (Dummy CHECKMULTISIG argument must be zero)"
3636

3737

38-
def trueDummy(tx):
38+
def invalidate_nulldummy_tx(tx):
3939
"""Transform a NULLDUMMY compliant tx (i.e. scriptSig starts with OP_0)
4040
to be non-NULLDUMMY compliant by replacing the dummy with OP_TRUE"""
4141
assert_equal(tx.vin[0].scriptSig[0], OP_0)
@@ -92,7 +92,7 @@ def run_test(self):
9292

9393
self.log.info("Test 2: Non-NULLDUMMY base multisig transaction should not be accepted to mempool before activation")
9494
test2tx = create_transaction(self.nodes[0], txid2, self.ms_address, amount=47)
95-
trueDummy(test2tx)
95+
invalidate_nulldummy_tx(test2tx)
9696
assert_raises_rpc_error(-26, NULLDUMMY_ERROR, self.nodes[0].sendrawtransaction, test2tx.serialize_with_witness().hex(), 0)
9797

9898
self.log.info(f"Test 3: Non-NULLDUMMY base transactions should be accepted in a block before activation [{COINBASE_MATURITY + 4}]")
@@ -101,7 +101,7 @@ def run_test(self):
101101
self.log.info("Test 4: Non-NULLDUMMY base multisig transaction is invalid after activation")
102102
test4tx = create_transaction(self.nodes[0], test2tx.hash, self.address, amount=46)
103103
test6txs = [CTransaction(test4tx)]
104-
trueDummy(test4tx)
104+
invalidate_nulldummy_tx(test4tx)
105105
assert_raises_rpc_error(-26, NULLDUMMY_ERROR, self.nodes[0].sendrawtransaction, test4tx.serialize_with_witness().hex(), 0)
106106
self.block_submit(self.nodes[0], [test4tx], accept=False)
107107

0 commit comments

Comments
 (0)