Skip to content

Commit 5cc083c

Browse files
fanquakefanquake
committed
Merge bitcoin/bitcoin#23473: build: boring autotools cleanup
34094af build: consistently quote AC_CHECK_LIB() arguments (fanquake) efd4fe1 build: consistently quote AC_MSG_* arguments (fanquake) c397326 build: consistently quote AC_CHECK_PROG() arguments (fanquake) 80762df build: consistently quote arguments in AC_ARG_VAR() (fanquake) e6749a4 build: consistently quote arguments in AM_CONDITIONAL() (fanquake) cdb47e1 build: consistently quote AC_DEFINE() arguments (fanquake) a17a3f9 build: consistently quote AC_MSG_CHECKING() arguments (fanquake) 50d99f2 build: consistently quote AC_PATH_TOOL arguments (fanquake) 05923e7 build: AC_PATH_PROG(S) consistently quote arguments (fanquake) 407f3a4 build: cleanup AX_CHECK_PREPROC_FLAG() usage (fanquake) b4dba0c build: AX_CHECK_PREPROC_FLAG() serial 6 (fanquake) 5ced925 build: cleanup AX_CHECK_COMPILE_FLAG() usage (fanquake) b3dd6c1 build: AX_CHECK_COMPILE_FLAG() serial 6 (fanquake) 5e6bc43 build: cleanup AX_CHECK_LINK_FLAG() usage (fanquake) a874637 build: AX_CHECK_LINK_FLAG serial 6 (fanquake) Pull request description: This is mostly just being consistent with how we do things, and migrating towards a style (we have already been doing so ad-hoc) that is clearer for anyone who cares to read `.m4`. For example: `master`: ```m4 AX_CHECK_COMPILE_FLAG( [-g3], [[DEBUG_CXXFLAGS="$DEBUG_CXXFLAGS -g3"]], [AX_CHECK_COMPILE_FLAG([-g],[[DEBUG_CXXFLAGS="$DEBUG_CXXFLAGS -g"]],,[[$CXXFLAG_WERROR]])], [[$CXXFLAG_WERROR]]) ``` This PR: ```m4 AX_CHECK_COMPILE_FLAG( [-g3], [DEBUG_CXXFLAGS="$DEBUG_CXXFLAGS -g3"], [AX_CHECK_COMPILE_FLAG([-g], [DEBUG_CXXFLAGS="$DEBUG_CXXFLAGS -g"], [], [$CXXFLAG_WERROR])], [$CXXFLAG_WERROR]) ``` Drop unneeded double-quoting (which we use inconsistently), use `[]` for empty arguments, space things out. There should be no functional change, before & after binaries identical. Very boring. Guix build: ```bash bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum 22097cd621cd88348f827b916f4b4b120b40c3515a3752595347e36d57dc9158 guix-build-34094aff1348/output/aarch64-linux-gnu/SHA256SUMS.part 43f10bb857afa7ea52a8ed9beed36ff0e3ee02dba31100fc04c8e0b2443d94eb guix-build-34094aff1348/output/aarch64-linux-gnu/bitcoin-34094aff1348-aarch64-linux-gnu-debug.tar.gz 9095a8228376094065103f4adc9cdcb8189111fb9536ad88e4f8cecc3df6fc75 guix-build-34094aff1348/output/aarch64-linux-gnu/bitcoin-34094aff1348-aarch64-linux-gnu.tar.gz 9c73179059c6fe1f7643445ec5a530003fc41187aa0a94cb1f5c106097161e5b guix-build-34094aff1348/output/arm-linux-gnueabihf/SHA256SUMS.part 70ddd4dd0a06c7491937084125f690c1d62fa2647c16048fc1a4a9a09d8b10b4 guix-build-34094aff1348/output/arm-linux-gnueabihf/bitcoin-34094aff1348-arm-linux-gnueabihf-debug.tar.gz 0a338fdc9788c33a0d519b6c09fdf6271e3bd68846ee61eef0a06a2df6bab419 guix-build-34094aff1348/output/arm-linux-gnueabihf/bitcoin-34094aff1348-arm-linux-gnueabihf.tar.gz 25eda7fae2984b9dadf47420d1dc09b0224d425144233482602bd9e6d348255c guix-build-34094aff1348/output/dist-archive/bitcoin-34094aff1348.tar.gz d70d84e43ffa2d809063cda868f708539e9114b2d14edb6ddcf05fdf73f3187b guix-build-34094aff1348/output/powerpc64-linux-gnu/SHA256SUMS.part 8d1291e576d2b5f8f7120fe6e6ed4b23415249e22a657a350ccce68ff261e088 guix-build-34094aff1348/output/powerpc64-linux-gnu/bitcoin-34094aff1348-powerpc64-linux-gnu-debug.tar.gz eab448186aee18ac33c39eed4d24501208d10d257fe6e2739adf589b1d4b693a guix-build-34094aff1348/output/powerpc64-linux-gnu/bitcoin-34094aff1348-powerpc64-linux-gnu.tar.gz 4d28617b4d0ddb88c8b20d06ca21314ee40814043f92cabcd9ea3e3d8ee39183 guix-build-34094aff1348/output/powerpc64le-linux-gnu/SHA256SUMS.part dea02168e170e92600012f5806ec8b39209282c2270669f2040682f74bc3f320 guix-build-34094aff1348/output/powerpc64le-linux-gnu/bitcoin-34094aff1348-powerpc64le-linux-gnu-debug.tar.gz c7122e89d3186a183ac08e7f3020654722c98bf8acc8b790bb292b39f5ba8225 guix-build-34094aff1348/output/powerpc64le-linux-gnu/bitcoin-34094aff1348-powerpc64le-linux-gnu.tar.gz 0802a52720d2bec1264dc13f6554a9da347baa3d096242b29bb524f4b121eb10 guix-build-34094aff1348/output/riscv64-linux-gnu/SHA256SUMS.part 4aee9fc41f35d2adb2d0562902dd8584a8413a73c015ddcdcef00586779f63a7 guix-build-34094aff1348/output/riscv64-linux-gnu/bitcoin-34094aff1348-riscv64-linux-gnu-debug.tar.gz 3f0c4d6096ac7e08389e851c2d252632c044a700ce0174473ac4d7f66290e8cc guix-build-34094aff1348/output/riscv64-linux-gnu/bitcoin-34094aff1348-riscv64-linux-gnu.tar.gz c5149c46b9b7081d5715daf3e22fd30ffca23d333f664da1fabc8143ff8bf76c guix-build-34094aff1348/output/x86_64-apple-darwin19/SHA256SUMS.part 81848355751e55a8a60636e3ea2f03ca6abb78736a5431715cd51cebd46bb961 guix-build-34094aff1348/output/x86_64-apple-darwin19/bitcoin-34094aff1348-osx-unsigned.dmg d2f6f689cbedddd865f90dba9ddf21479c71c61b0350fda62804b2f233116a43 guix-build-34094aff1348/output/x86_64-apple-darwin19/bitcoin-34094aff1348-osx-unsigned.tar.gz 99d8fe428fcb67f9975e6b8d9a63d84946215a0a6b8f94967ce96cc3af4b7772 guix-build-34094aff1348/output/x86_64-apple-darwin19/bitcoin-34094aff1348-osx64.tar.gz 3dac13c7556d9a25ff5513bbb2638fe4fa74d8a88304bbdce52364df7832a3ab guix-build-34094aff1348/output/x86_64-linux-gnu/SHA256SUMS.part e4baa7da80fdabbb50953efaaa7b4867c7e575a7a156b728e8e197142df55697 guix-build-34094aff1348/output/x86_64-linux-gnu/bitcoin-34094aff1348-x86_64-linux-gnu-debug.tar.gz f82f5bcc7197c1741b106f62be7b468aadbdf5b3198091582026cd450bf13b3a guix-build-34094aff1348/output/x86_64-linux-gnu/bitcoin-34094aff1348-x86_64-linux-gnu.tar.gz db22b5f48783917f985920ddb26aa170b4d6cc65112406548847a883099505b8 guix-build-34094aff1348/output/x86_64-w64-mingw32/SHA256SUMS.part ead0809193ca1d462553a6f3f233cdbff7a3f8419100d825abfc10835508e485 guix-build-34094aff1348/output/x86_64-w64-mingw32/bitcoin-34094aff1348-win-unsigned.tar.gz e1006b6c114eaf33274144d8e9a20abc0cee01e26a4594063ee615bf09c1b344 guix-build-34094aff1348/output/x86_64-w64-mingw32/bitcoin-34094aff1348-win64-debug.zip 2d3fbc593b58d353a6859e02c0dd096d453cf5f1e3150c2a1c234bdfc97b4f24 guix-build-34094aff1348/output/x86_64-w64-mingw32/bitcoin-34094aff1348-win64-setup-unsigned.exe 25cfa8a3655727572593f100b7a70c1061fa6f3b017014ad7444059611c3ddda guix-build-34094aff1348/output/x86_64-w64-mingw32/bitcoin-34094aff1348-win64.zip ``` ACKs for top commit: hebasto: re-ACK 34094af Tree-SHA512: 7515e85b4dedddf430ddf0bf31f25fca8f73898cf2ba4b6a66b9f21feeaff4c2600fe24efdd2e81822f059827b5b35341b183ea8342fd689248d8c355bf5cb42
2 parents c9dd5c8 + 34094af commit 5cc083c

File tree

6 files changed

+317
-382
lines changed

6 files changed

+317
-382
lines changed

‎build-aux/m4/ax_check_compile_flag.m4

Lines changed: 6 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# ===========================================================================
2-
# http://www.gnu.org/software/autoconf-archive/ax_check_compile_flag.html
2+
# https://www.gnu.org/software/autoconf-archive/ax_check_compile_flag.html
33
# ===========================================================================
44
#
55
# SYNOPSIS
@@ -29,33 +29,12 @@
2929
# Copyright (c) 2008 Guido U. Draheim <[email protected]>
3030
# Copyright (c) 2011 Maarten Bosmans <[email protected]>
3131
#
32-
# This program is free software: you can redistribute it and/or modify it
33-
# under the terms of the GNU General Public License as published by the
34-
# Free Software Foundation, either version 3 of the License, or (at your
35-
# option) any later version.
36-
#
37-
# This program is distributed in the hope that it will be useful, but
38-
# WITHOUT ANY WARRANTY; without even the implied warranty of
39-
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General
40-
# Public License for more details.
41-
#
42-
# You should have received a copy of the GNU General Public License along
43-
# with this program. If not, see <http://www.gnu.org/licenses/>.
44-
#
45-
# As a special exception, the respective Autoconf Macro's copyright owner
46-
# gives unlimited permission to copy, distribute and modify the configure
47-
# scripts that are the output of Autoconf when processing the Macro. You
48-
# need not follow the terms of the GNU General Public License when using
49-
# or distributing such scripts, even though portions of the text of the
50-
# Macro appear in them. The GNU General Public License (GPL) does govern
51-
# all other use of the material that constitutes the Autoconf Macro.
52-
#
53-
# This special exception to the GPL applies to versions of the Autoconf
54-
# Macro released by the Autoconf Archive. When you make and distribute a
55-
# modified version of the Autoconf Macro, you may extend this special
56-
# exception to the GPL to apply to your modified version as well.
32+
# Copying and distribution of this file, with or without modification, are
33+
# permitted in any medium without royalty provided the copyright notice
34+
# and this notice are preserved. This file is offered as-is, without any
35+
# warranty.
5736

58-
#serial 4
37+
#serial 6
5938

6039
AC_DEFUN([AX_CHECK_COMPILE_FLAG],
6140
[AC_PREREQ(2.64)dnl for _AC_LANG_PREFIX and AS_VAR_IF

‎build-aux/m4/ax_check_link_flag.m4

Lines changed: 6 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# ===========================================================================
2-
# http://www.gnu.org/software/autoconf-archive/ax_check_link_flag.html
2+
# https://www.gnu.org/software/autoconf-archive/ax_check_link_flag.html
33
# ===========================================================================
44
#
55
# SYNOPSIS
@@ -29,33 +29,12 @@
2929
# Copyright (c) 2008 Guido U. Draheim <[email protected]>
3030
# Copyright (c) 2011 Maarten Bosmans <[email protected]>
3131
#
32-
# This program is free software: you can redistribute it and/or modify it
33-
# under the terms of the GNU General Public License as published by the
34-
# Free Software Foundation, either version 3 of the License, or (at your
35-
# option) any later version.
36-
#
37-
# This program is distributed in the hope that it will be useful, but
38-
# WITHOUT ANY WARRANTY; without even the implied warranty of
39-
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General
40-
# Public License for more details.
41-
#
42-
# You should have received a copy of the GNU General Public License along
43-
# with this program. If not, see <http://www.gnu.org/licenses/>.
44-
#
45-
# As a special exception, the respective Autoconf Macro's copyright owner
46-
# gives unlimited permission to copy, distribute and modify the configure
47-
# scripts that are the output of Autoconf when processing the Macro. You
48-
# need not follow the terms of the GNU General Public License when using
49-
# or distributing such scripts, even though portions of the text of the
50-
# Macro appear in them. The GNU General Public License (GPL) does govern
51-
# all other use of the material that constitutes the Autoconf Macro.
52-
#
53-
# This special exception to the GPL applies to versions of the Autoconf
54-
# Macro released by the Autoconf Archive. When you make and distribute a
55-
# modified version of the Autoconf Macro, you may extend this special
56-
# exception to the GPL to apply to your modified version as well.
32+
# Copying and distribution of this file, with or without modification, are
33+
# permitted in any medium without royalty provided the copyright notice
34+
# and this notice are preserved. This file is offered as-is, without any
35+
# warranty.
5736

58-
#serial 4
37+
#serial 6
5938

6039
AC_DEFUN([AX_CHECK_LINK_FLAG],
6140
[AC_PREREQ(2.64)dnl for _AC_LANG_PREFIX and AS_VAR_IF

‎build-aux/m4/ax_check_preproc_flag.m4

Lines changed: 6 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# ===========================================================================
2-
# http://www.gnu.org/software/autoconf-archive/ax_check_preproc_flag.html
2+
# https://www.gnu.org/software/autoconf-archive/ax_check_preproc_flag.html
33
# ===========================================================================
44
#
55
# SYNOPSIS
@@ -29,33 +29,12 @@
2929
# Copyright (c) 2008 Guido U. Draheim <[email protected]>
3030
# Copyright (c) 2011 Maarten Bosmans <[email protected]>
3131
#
32-
# This program is free software: you can redistribute it and/or modify it
33-
# under the terms of the GNU General Public License as published by the
34-
# Free Software Foundation, either version 3 of the License, or (at your
35-
# option) any later version.
36-
#
37-
# This program is distributed in the hope that it will be useful, but
38-
# WITHOUT ANY WARRANTY; without even the implied warranty of
39-
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General
40-
# Public License for more details.
41-
#
42-
# You should have received a copy of the GNU General Public License along
43-
# with this program. If not, see <http://www.gnu.org/licenses/>.
44-
#
45-
# As a special exception, the respective Autoconf Macro's copyright owner
46-
# gives unlimited permission to copy, distribute and modify the configure
47-
# scripts that are the output of Autoconf when processing the Macro. You
48-
# need not follow the terms of the GNU General Public License when using
49-
# or distributing such scripts, even though portions of the text of the
50-
# Macro appear in them. The GNU General Public License (GPL) does govern
51-
# all other use of the material that constitutes the Autoconf Macro.
52-
#
53-
# This special exception to the GPL applies to versions of the Autoconf
54-
# Macro released by the Autoconf Archive. When you make and distribute a
55-
# modified version of the Autoconf Macro, you may extend this special
56-
# exception to the GPL to apply to your modified version as well.
32+
# Copying and distribution of this file, with or without modification, are
33+
# permitted in any medium without royalty provided the copyright notice
34+
# and this notice are preserved. This file is offered as-is, without any
35+
# warranty.
5736

58-
#serial 4
37+
#serial 6
5938

6039
AC_DEFUN([AX_CHECK_PREPROC_FLAG],
6140
[AC_PREREQ(2.64)dnl for _AC_LANG_PREFIX and AS_VAR_IF

‎build-aux/m4/bitcoin_find_bdb48.m4

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ dnl Distributed under the MIT software license, see the accompanying
33
dnl file COPYING or http://www.opensource.org/licenses/mit-license.php.
44

55
AC_DEFUN([BITCOIN_FIND_BDB48],[
6-
AC_ARG_VAR(BDB_CFLAGS, [C compiler flags for BerkeleyDB, bypasses autodetection])
7-
AC_ARG_VAR(BDB_LIBS, [Linker flags for BerkeleyDB, bypasses autodetection])
6+
AC_ARG_VAR([BDB_CFLAGS], [C compiler flags for BerkeleyDB, bypasses autodetection])
7+
AC_ARG_VAR([BDB_LIBS], [Linker flags for BerkeleyDB, bypasses autodetection])
88
99
if test "x$use_bdb" = "xno"; then
1010
use_bdb=no

‎build-aux/m4/bitcoin_qt.m4

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ dnl Output: $1 is set to the path of $2 if found. $2 are searched in order.
3636
AC_DEFUN([BITCOIN_QT_PATH_PROGS],[
3737
BITCOIN_QT_CHECK([
3838
if test "x$3" != x; then
39-
AC_PATH_PROGS($1,$2,,$3)
39+
AC_PATH_PROGS([$1], [$2], [], [$3])
4040
else
41-
AC_PATH_PROGS($1,$2)
41+
AC_PATH_PROGS([$1], [$2])
4242
fi
4343
if test "x$$1" = x && test "x$4" != xyes; then
4444
BITCOIN_QT_FAIL([$1 not found])
@@ -136,34 +136,34 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
136136
fi
137137
fi
138138
139-
AC_DEFINE(QT_STATICPLUGIN, 1, [Define this symbol if qt plugins are static])
139+
AC_DEFINE([QT_STATICPLUGIN], [1], [Define this symbol if qt plugins are static])
140140
if test "x$TARGET_OS" != xandroid; then
141141
_BITCOIN_QT_CHECK_STATIC_PLUGIN([QMinimalIntegrationPlugin], [-lqminimal])
142-
AC_DEFINE(QT_QPA_PLATFORM_MINIMAL, 1, [Define this symbol if the minimal qt platform exists])
142+
AC_DEFINE([QT_QPA_PLATFORM_MINIMAL], [1], [Define this symbol if the minimal qt platform exists])
143143
fi
144144
if test "x$TARGET_OS" = xwindows; then
145145
dnl Linking against wtsapi32 is required. See #17749 and
146146
dnl https://bugreports.qt.io/browse/QTBUG-27097.
147147
AX_CHECK_LINK_FLAG([-lwtsapi32], [QT_LIBS="$QT_LIBS -lwtsapi32"], [AC_MSG_ERROR([could not link against -lwtsapi32])])
148148
_BITCOIN_QT_CHECK_STATIC_PLUGIN([QWindowsIntegrationPlugin], [-lqwindows])
149149
_BITCOIN_QT_CHECK_STATIC_PLUGIN([QWindowsVistaStylePlugin], [-lqwindowsvistastyle])
150-
AC_DEFINE(QT_QPA_PLATFORM_WINDOWS, 1, [Define this symbol if the qt platform is windows])
150+
AC_DEFINE([QT_QPA_PLATFORM_WINDOWS], [1], [Define this symbol if the qt platform is windows])
151151
elif test "x$TARGET_OS" = xlinux; then
152152
dnl workaround for https://bugreports.qt.io/browse/QTBUG-74874
153153
AX_CHECK_LINK_FLAG([-lxcb-shm], [QT_LIBS="$QT_LIBS -lxcb-shm"], [AC_MSG_ERROR([could not link against -lxcb-shm])])
154154
_BITCOIN_QT_CHECK_STATIC_PLUGIN([QXcbIntegrationPlugin], [-lqxcb])
155-
AC_DEFINE(QT_QPA_PLATFORM_XCB, 1, [Define this symbol if the qt platform is xcb])
155+
AC_DEFINE([QT_QPA_PLATFORM_XCB], [1], [Define this symbol if the qt platform is xcb])
156156
elif test "x$TARGET_OS" = xdarwin; then
157-
AX_CHECK_LINK_FLAG([[-framework Carbon]],[QT_LIBS="$QT_LIBS -framework Carbon"],[AC_MSG_ERROR(could not link against Carbon framework)])
158-
AX_CHECK_LINK_FLAG([[-framework IOSurface]],[QT_LIBS="$QT_LIBS -framework IOSurface"],[AC_MSG_ERROR(could not link against IOSurface framework)])
159-
AX_CHECK_LINK_FLAG([[-framework Metal]],[QT_LIBS="$QT_LIBS -framework Metal"],[AC_MSG_ERROR(could not link against Metal framework)])
160-
AX_CHECK_LINK_FLAG([[-framework QuartzCore]],[QT_LIBS="$QT_LIBS -framework QuartzCore"],[AC_MSG_ERROR(could not link against QuartzCore framework)])
157+
AX_CHECK_LINK_FLAG([-framework Carbon], [QT_LIBS="$QT_LIBS -framework Carbon"], [AC_MSG_ERROR(could not link against Carbon framework)])
158+
AX_CHECK_LINK_FLAG([-framework IOSurface], [QT_LIBS="$QT_LIBS -framework IOSurface"], [AC_MSG_ERROR(could not link against IOSurface framework)])
159+
AX_CHECK_LINK_FLAG([-framework Metal], [QT_LIBS="$QT_LIBS -framework Metal"], [AC_MSG_ERROR(could not link against Metal framework)])
160+
AX_CHECK_LINK_FLAG([-framework QuartzCore], [QT_LIBS="$QT_LIBS -framework QuartzCore"], [AC_MSG_ERROR(could not link against QuartzCore framework)])
161161
_BITCOIN_QT_CHECK_STATIC_PLUGIN([QCocoaIntegrationPlugin], [-lqcocoa])
162162
_BITCOIN_QT_CHECK_STATIC_PLUGIN([QMacStylePlugin], [-lqmacstyle])
163-
AC_DEFINE(QT_QPA_PLATFORM_COCOA, 1, [Define this symbol if the qt platform is cocoa])
163+
AC_DEFINE([QT_QPA_PLATFORM_COCOA], [1], [Define this symbol if the qt platform is cocoa])
164164
elif test "x$TARGET_OS" = xandroid; then
165165
QT_LIBS="-Wl,--export-dynamic,--undefined=JNI_OnLoad -lqtforandroid -ljnigraphics -landroid -lqtfreetype $QT_LIBS"
166-
AC_DEFINE(QT_QPA_PLATFORM_ANDROID, 1, [Define this symbol if the qt platform is android])
166+
AC_DEFINE([QT_QPA_PLATFORM_ANDROID], [1], [Define this symbol if the qt platform is android])
167167
fi
168168
fi
169169
CPPFLAGS=$TEMP_CPPFLAGS
@@ -176,7 +176,7 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
176176
177177
if test "x$use_hardening" != xno; then
178178
BITCOIN_QT_CHECK([
179-
AC_MSG_CHECKING(whether -fPIE can be used with this Qt config)
179+
AC_MSG_CHECKING([whether -fPIE can be used with this Qt config])
180180
TEMP_CPPFLAGS=$CPPFLAGS
181181
TEMP_CXXFLAGS=$CXXFLAGS
182182
CPPFLAGS="$QT_INCLUDES $CPPFLAGS"
@@ -192,15 +192,15 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
192192
choke
193193
#endif
194194
]])],
195-
[ AC_MSG_RESULT(yes); QT_PIE_FLAGS=$PIE_FLAGS ],
196-
[ AC_MSG_RESULT(no); QT_PIE_FLAGS=$PIC_FLAGS]
195+
[ AC_MSG_RESULT([yes]); QT_PIE_FLAGS=$PIE_FLAGS ],
196+
[ AC_MSG_RESULT([no]); QT_PIE_FLAGS=$PIC_FLAGS]
197197
)
198198
CPPFLAGS=$TEMP_CPPFLAGS
199199
CXXFLAGS=$TEMP_CXXFLAGS
200200
])
201201
else
202202
BITCOIN_QT_CHECK([
203-
AC_MSG_CHECKING(whether -fPIC is needed with this Qt config)
203+
AC_MSG_CHECKING([whether -fPIC is needed with this Qt config])
204204
TEMP_CPPFLAGS=$CPPFLAGS
205205
CPPFLAGS="$QT_INCLUDES $CPPFLAGS"
206206
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
@@ -214,8 +214,8 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
214214
choke
215215
#endif
216216
]])],
217-
[ AC_MSG_RESULT(no)],
218-
[ AC_MSG_RESULT(yes); QT_PIE_FLAGS=$PIC_FLAGS]
217+
[ AC_MSG_RESULT([no])],
218+
[ AC_MSG_RESULT([yes]); QT_PIE_FLAGS=$PIC_FLAGS]
219219
)
220220
CPPFLAGS=$TEMP_CPPFLAGS
221221
])
@@ -234,12 +234,12 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
234234
BITCOIN_QT_CHECK([
235235
MOC_DEFS="${MOC_DEFS} -DQ_OS_MAC"
236236
base_frameworks="-framework Foundation -framework AppKit"
237-
AX_CHECK_LINK_FLAG([[$base_frameworks]],[QT_LIBS="$QT_LIBS $base_frameworks"],[AC_MSG_ERROR(could not find base frameworks)])
237+
AX_CHECK_LINK_FLAG([$base_frameworks], [QT_LIBS="$QT_LIBS $base_frameworks"], [AC_MSG_ERROR(could not find base frameworks)])
238238
])
239239
;;
240240
*mingw*)
241241
BITCOIN_QT_CHECK([
242-
AX_CHECK_LINK_FLAG([[-mwindows]],[QT_LDFLAGS="$QT_LDFLAGS -mwindows"],[AC_MSG_WARN(-mwindows linker support not detected)])
242+
AX_CHECK_LINK_FLAG([-mwindows], [QT_LDFLAGS="$QT_LDFLAGS -mwindows"], [AC_MSG_WARN([-mwindows linker support not detected])])
243243
])
244244
esac
245245

0 commit comments

Comments
 (0)