net: do not break when addr is not from a distinct network group

brunoerg · brunoerg · commit 5fa405545286 · 2023-06-12T13:58:45.000-03:00
When the address is from a network group we already caught,
do a `continue` and try to find another address until conditions
are met or we reach the limit (`nTries`).
diff --git a/src/net.cpp b/src/net.cpp
@@ -1853,7 +1853,7 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect)
 
             // Require outbound IPv4/IPv6 connections, other than feelers, to be to distinct network groups
             if (!fFeeler && outbound_ipv46_peer_netgroups.count(m_netgroupman.GetGroup(addr))) {
-                break;
+                continue;
             }
 
             // if we selected an invalid or local address, restart

Original file line number	Diff line number	Diff line change
`@@ -1853,7 +1853,7 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect)`
`1853`	`1853`
`1854`	`1854`	`// Require outbound IPv4/IPv6 connections, other than feelers, to be to distinct network groups`
`1855`	`1855`	`if (!fFeeler && outbound_ipv46_peer_netgroups.count(m_netgroupman.GetGroup(addr))) {`
`1856`		`- break;`
	`1856`	`+ continue;`
`1857`	`1857`	`}`
`1858`	`1858`
`1859`	`1859`	`// if we selected an invalid or local address, restart`