net: wait until the node is destroyed to delete its recv buffer

theuni · theuni · commit 60425870d78c · 2017-01-04T09:29:14.000-05:00
when vRecvMsg becomes a private buffer, it won't make sense to allow other
threads to mess with it anymore.
diff --git a/src/net.cpp b/src/net.cpp
@@ -437,11 +437,6 @@ void CNode::CloseSocketDisconnect()
         LogPrint("net", "disconnecting peer=%d\n", id);
         CloseSocket(hSocket);
     }
-
-    // in case this fails, we'll empty the recv buffer when the CNode is deleted
-    TRY_LOCK(cs_vRecvMsg, lockRecv);
-    if (lockRecv)
-        vRecvMsg.clear();
 }
 
 void CConnman::ClearBanned()

Original file line number	Diff line number	Diff line change
`@@ -437,11 +437,6 @@ void CNode::CloseSocketDisconnect()`
`437`	`437`	`LogPrint("net", "disconnecting peer=%d\n", id);`
`438`	`438`	`CloseSocket(hSocket);`
`439`	`439`	`}`
`440`		`-`
`441`		`- // in case this fails, we'll empty the recv buffer when the CNode is deleted`
`442`		`- TRY_LOCK(cs_vRecvMsg, lockRecv);`
`443`		`- if (lockRecv)`
`444`		`- vRecvMsg.clear();`
`445`	`440`	`}`
`446`	`441`
`447`	`442`	`void CConnman::ClearBanned()`