test: Report InitBlockIndex result

laanwj · laanwj · commit 64854666f57d · 2017-03-02T14:54:47.000+01:00
If InitBlockIndex fails, then it will segfault later. Same for the later
ActivateBestChain. BOOST_REQUIRE the result, so that an error will be
reported and the test case aborted.
diff --git a/src/test/test_bitcoin.cpp b/src/test/test_bitcoin.cpp
@@ -69,11 +69,11 @@ TestingSetup::TestingSetup(const std::string& chainName) : BasicTestingSetup(cha
         pblocktree = new CBlockTreeDB(1 << 20, true);
         pcoinsdbview = new CCoinsViewDB(1 << 23, true);
         pcoinsTip = new CCoinsViewCache(pcoinsdbview);
-        InitBlockIndex(chainparams);
+        BOOST_REQUIRE(InitBlockIndex(chainparams));
         {
             CValidationState state;
             bool ok = ActivateBestChain(state, chainparams);
-            BOOST_CHECK(ok);
+            BOOST_REQUIRE(ok);
         }
         nScriptCheckThreads = 3;
         for (int i=0; i < nScriptCheckThreads-1; i++)

Original file line number	Diff line number	Diff line change
`@@ -69,11 +69,11 @@ TestingSetup::TestingSetup(const std::string& chainName) : BasicTestingSetup(cha`
`69`	`69`	`pblocktree = new CBlockTreeDB(1 << 20, true);`
`70`	`70`	`pcoinsdbview = new CCoinsViewDB(1 << 23, true);`
`71`	`71`	`pcoinsTip = new CCoinsViewCache(pcoinsdbview);`
`72`		`- InitBlockIndex(chainparams);`
	`72`	`+ BOOST_REQUIRE(InitBlockIndex(chainparams));`
`73`	`73`	`{`
`74`	`74`	`CValidationState state;`
`75`	`75`	`bool ok = ActivateBestChain(state, chainparams);`
`76`		`- BOOST_CHECK(ok);`
	`76`	`+ BOOST_REQUIRE(ok);`
`77`	`77`	`}`
`78`	`78`	`nScriptCheckThreads = 3;`
`79`	`79`	`for (int i=0; i < nScriptCheckThreads-1; i++)`