CBlockLocator: performance-move-const-arg Clang tidy fixups

Co-authored-by: "Pieter Wuille <[email protected]>"
Co-authored-by: "Vasil Dimov <[email protected]>"
Co-authored-by: "MarcoFalke <[email protected]>"

Author: jonatack

src/chain.cpp

@@ -49,7 +49,7 @@ std::vector<uint256> LocatorEntries(const CBlockIndex* index)
 
 CBlockLocator GetLocator(const CBlockIndex* index)
 {
-    return CBlockLocator{std::move(LocatorEntries(index))};
+    return CBlockLocator{LocatorEntries(index)};
 }
 
 CBlockLocator CChain::GetLocator() const

src/primitives/block.h

@@ -123,7 +123,7 @@ struct CBlockLocator
 
     CBlockLocator() {}
 
-    explicit CBlockLocator(const std::vector<uint256>& vHaveIn) : vHave(vHaveIn) {}
+    explicit CBlockLocator(std::vector<uint256>&& have) : vHave(std::move(have)) {}
 
     SERIALIZE_METHODS(CBlockLocator, obj)
     {