Skip to content

Commit 6cd1e0f

Browse files
author
MarcoFalke
committed
Merge bitcoin/bitcoin#23728: Use the imperative mood in example subject line
efde111 Use the imperative mood in example subject line (Tobin Harding) Pull request description: The section `Committing Patches` within `CONTIBUTING.md` contains an example commit subject line that violates rule seven of the linked guide to writing commit logs (Chris Beams famous blog post). We should practice what we preach, especially in examples :) Use the imperative mood in example commit message subject line. ACKs for top commit: jarolrod: ACK efde111 shaavan: ACK efde111 Tree-SHA512: f607951020c544a65df2fcb45f40f10d44bc761298d866ef3d3742c63ed21eed4e7a798c361f8449d05781c04133b60f0b78d4402a8235064953a817bb24c7d0
2 parents 09ad512 + efde111 commit 6cd1e0f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ own without warnings, errors, regressions, or test failures.
119119

120120
Commit messages should be verbose by default consisting of a short subject line
121121
(50 chars max), a blank line and detailed explanatory text as separate
122-
paragraph(s), unless the title alone is self-explanatory (like "Corrected typo
122+
paragraph(s), unless the title alone is self-explanatory (like "Correct typo
123123
in init.cpp") in which case a single title line is sufficient. Commit messages should be
124124
helpful to people reading your code in the future, so explain the reasoning for
125125
your decisions. Further explanation [here](https://chris.beams.io/posts/git-commit/).

0 commit comments

Comments
 (0)