refactor: Use explicit function type instead of template

hebasto · hebasto · commit 73f71e19965e · 2020-09-19T17:50:58.000+03:00
diff --git a/src/net.h b/src/net.h
@@ -258,8 +258,8 @@ class CConnman
 
     void PushMessage(CNode* pnode, CSerializedNetMsg&& msg);
 
-    template<typename Callable>
-    void ForEachNode(Callable&& func)
+    using NodeFn = std::function<void(CNode*)>;
+    void ForEachNode(const NodeFn& func)
     {
         LOCK(cs_vNodes);
         for (auto&& node : vNodes) {
@@ -268,8 +268,7 @@ class CConnman
         }
     };
 
-    template<typename Callable>
-    void ForEachNode(Callable&& func) const
+    void ForEachNode(const NodeFn& func) const
     {
         LOCK(cs_vNodes);
         for (auto&& node : vNodes) {

Original file line number	Diff line number	Diff line change
`@@ -258,8 +258,8 @@ class CConnman`
`258`	`258`
`259`	`259`	`void PushMessage(CNode* pnode, CSerializedNetMsg&& msg);`
`260`	`260`
`261`		`- template<typename Callable>`
`262`		`- void ForEachNode(Callable&& func)`
	`261`	`+ using NodeFn = std::function<void(CNode*)>;`
	`262`	`+ void ForEachNode(const NodeFn& func)`
`263`	`263`	`{`
`264`	`264`	`LOCK(cs_vNodes);`
`265`	`265`	`for (auto&& node : vNodes) {`
`@@ -268,8 +268,7 @@ class CConnman`
`268`	`268`	`}`
`269`	`269`	`};`
`270`	`270`
`271`		`- template<typename Callable>`
`272`		`- void ForEachNode(Callable&& func) const`
	`271`	`+ void ForEachNode(const NodeFn& func) const`
`273`	`272`	`{`
`274`	`273`	`LOCK(cs_vNodes);`
`275`	`274`	`for (auto&& node : vNodes) {`