Skip to content

Commit 761fe07

Browse files
author
MarcoFalke
committed
Merge #16768: test: Make lint-includes.sh work from any directory
490da63 Make lint-includes.sh work from any directory (Kristaps Kaupe) Pull request description: Before this change it works from root folder of bitcoin git repo, but if you do `cd test/lint; ./test-includes.sh`, you will have a lot of false positive messages like this: ``` Good job! The circular dependency "chainparamsbase -> util/system -> chainparamsbase" is no longer present. Please remove it from EXPECTED_CIRCULAR_DEPENDENCIES in ./lint-circular-dependencies.sh to make sure this circular dependency is not accidentally reintroduced. Good job! The circular dependency "index/txindex -> validation -> index/txindex" is no longer present. Please remove it from EXPECTED_CIRCULAR_DEPENDENCIES in ./lint-circular-dependencies.sh to make sure this circular dependency is not accidentally reintroduced. ``` Top commit has no ACKs. Tree-SHA512: 07fa69cb2883181dcee922191acac4b242722eeb2916cdffdc7163421302b22f3c9525aaf4c754a9dba1c307032c05285e38191d5c6aabc894321f8a27bbceaa
2 parents 8e00a68 + 490da63 commit 761fe07

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

test/lint/lint-includes.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
export LC_ALL=C
1212
IGNORE_REGEXP="/(leveldb|secp256k1|univalue)/"
1313

14+
# cd to root folder of git repo for git ls-files to work properly
15+
cd "$(dirname $0)/../.." || exit 1
16+
1417
filter_suffix() {
1518
git ls-files | grep -E "^src/.*\.${1}"'$' | grep -Ev "${IGNORE_REGEXP}"
1619
}

0 commit comments

Comments
 (0)