Merge #15451: [doc] clarify getdata limit after #14897

MarcoFalke · MarcoFalke · commit 762cbd287f63 · 2020-12-25T09:43:25.000+01:00
c119ba3 [doc] clarify getdata limit after #14897 (Michael Polzer) Pull request description: GETDATA is limited to blocks and transactions now and can't be used for other non-block data ACKs for top commit: laanwj: ACK c119ba3 theStack: ACK bitcoin/bitcoin@c119ba3 benthecarman: ACK c119ba3 Tree-SHA512: d6e9c109bcce4ef004ec83a9ec591163279476524dec97ed5f5c34e322dca35af66a168f0878ff972bbcec79d81623903f3619fedf8f88cdced3f3f66a779173
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
@@ -4591,7 +4591,7 @@ bool PeerManager::SendMessages(CNode* pto)
         }
 
         //
-        // Message: getdata (non-blocks)
+        // Message: getdata (transactions)
         //
         std::vector<std::pair<NodeId, GenTxid>> expired;
         auto requestable = m_txrequest.GetRequestable(pto->GetId(), current_time, &expired);

Original file line number	Diff line number	Diff line change
`@@ -4591,7 +4591,7 @@ bool PeerManager::SendMessages(CNode* pto)`
`4591`	`4591`	`}`
`4592`	`4592`
`4593`	`4593`	`//`
`4594`		`- // Message: getdata (non-blocks)`
	`4594`	`+ // Message: getdata (transactions)`
`4595`	`4595`	`//`
`4596`	`4596`	`std::vector<std::pair<NodeId, GenTxid>> expired;`
`4597`	`4597`	`auto requestable = m_txrequest.GetRequestable(pto->GetId(), current_time, &expired);`