Skip to content

Commit 76f031b

Browse files
committed
build: fix unoptimized libraries in depends
We need to append-to rather than set CXXFLAGS, otherwise we loose -O2 & -pipe. Currently this results in zeromq being built without optimizations at all (or whatever the compiler would default too, essentially always -O0). Bdb is the same, for the CXX portion of its code. C code has been built with -O2. Boost has actually been uneffected because it receives -O3 from it's own build flags.
1 parent 7be143a commit 76f031b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

depends/packages/bdb.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ $(package)_config_opts_mingw32=--enable-mingw
1212
$(package)_config_opts_linux=--with-pic
1313
$(package)_config_opts_android=--with-pic
1414
$(package)_cflags+=-Wno-error=implicit-function-declaration
15-
$(package)_cxxflags=-std=c++17
15+
$(package)_cxxflags+=-std=c++17
1616
$(package)_cppflags_mingw32=-DUNICODE -D_UNICODE
1717
endef
1818

depends/packages/boost.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ else
2323
$(package)_toolset_$(host_os)=gcc
2424
endif
2525
$(package)_config_libraries=filesystem,system,test
26-
$(package)_cxxflags=-std=c++17 -fvisibility=hidden
26+
$(package)_cxxflags+=-std=c++17 -fvisibility=hidden
2727
$(package)_cxxflags_linux=-fPIC
2828
$(package)_cxxflags_android=-fPIC
2929
$(package)_cxxflags_x86_64_darwin=-fcf-protection=full

depends/packages/zeromq.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ define $(package)_set_vars
1212
$(package)_config_opts += --disable-Werror --disable-drafts --enable-option-checking
1313
$(package)_config_opts_linux=--with-pic
1414
$(package)_config_opts_android=--with-pic
15-
$(package)_cxxflags=-std=c++17
15+
$(package)_cxxflags+=-std=c++17
1616
endef
1717

1818
define $(package)_preprocess_cmds

0 commit comments

Comments
 (0)